Attachment 211213 Details for Bug 98370 – Patch

[patch] Patch

bug-98370-20130910182616.patch (text/plain), 7.02 KB, created by Denis Nomiyama (dnomi) on 2013-09-10 10:26:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Denis Nomiyama (dnomi)

Created: 2013-09-10 10:26:04 PDT

Size: 7.02 KB

patch

obsolete

>Subversion Revision: 155453
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 653c76c916566311fc5480f1d6915f9d5c2fc6b9..993982e95f19e980f01aec609d4d5c0a674f5bc4 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,26 @@
>+2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
>+
>+        [GTK] accessibility/loading-iframe-sends-notification.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=98370
>+
>+        Reviewed by Chris Fleizach.
>+
>+        Enabled AXLayoutComplete on the GTK platform.
>+
>+        No new tests are required because this feature will use an existing
>+        accessibility layout test that is currently failing on the GTK+ platform
>+        (e.g. loading-iframe-sends-notification.html).
>+
>+        * accessibility/atk/AXObjectCacheAtk.cpp:
>+        (WebCore::AXObjectCache::postPlatformNotification): Send layout-complete
>+        signal in case of AXLayoutComplete.
>+        * dom/Document.cpp:
>+        (WebCore::Document::implicitClose): Enabled AXLayoutComplete on the GTK
>+        platform.
>+        * page/FrameView.cpp:
>+        (WebCore::FrameView::layout): Enabled AXLayoutComplete on the GTK
>+        platform.
>+
> 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
> 
>         REGRESSION (r147454): Youtube annotation links to new window broken
>diff --git a/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp b/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp
>index 154237de0ec77e8ed128848f8b6213124af83789..2cc09bde898828a325e8a7be6dbbc1e17ca9296d 100644
>--- a/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp
>+++ b/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp
>@@ -164,7 +164,9 @@ void AXObjectCache::postPlatformNotification(AccessibilityObject* coreObject, AX
>         atk_value_get_current_value(ATK_VALUE(axObject), &propertyValues.new_value);
> 
>         g_signal_emit_by_name(ATK_OBJECT(axObject), "property-change::accessible-value", &propertyValues, NULL);
>-    } else if (notification == AXInvalidStatusChanged)
>+    } else if (notification == AXLayoutComplete)
>+        g_signal_emit_by_name(axObject, "state-change", "layout-complete", true);
>+    else if (notification == AXInvalidStatusChanged)
>         g_signal_emit_by_name(axObject, "state-change", "invalid-entry", coreObject->invalidStatus() != "false");
> }
> 
>diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
>index acc6c1ea5180b5958a3c0137d83d5cee560c0221..a0ef5934e7ed09c49638c68e9ad488918edb4662 100644
>--- a/Source/WebCore/dom/Document.cpp
>+++ b/Source/WebCore/dom/Document.cpp
>@@ -2460,7 +2460,7 @@ void Document::implicitClose()
> 
>     m_processingLoadEvent = false;
> 
>-#if PLATFORM(MAC) || PLATFORM(WIN)
>+#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)
>     if (f && renderView() && AXObjectCache::accessibilityEnabled()) {
>         // The AX cache may have been cleared at this point, but we need to make sure it contains an
>         // AX object to send the notification to. getOrCreate will make sure that an valid AX object
>diff --git a/Source/WebCore/page/FrameView.cpp b/Source/WebCore/page/FrameView.cpp
>index fdb4979db298cf8af60f2824983447e5e8b0ff76..e7b313433b8c1e27afb4011491bcaf5b149dec88 100644
>--- a/Source/WebCore/page/FrameView.cpp
>+++ b/Source/WebCore/page/FrameView.cpp
>@@ -1312,7 +1312,7 @@ void FrameView::layout(bool allowSubtree)
>     
>     m_layoutCount++;
> 
>-#if PLATFORM(MAC) || PLATFORM(WIN)
>+#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)
>     if (AXObjectCache* cache = root->document().existingAXObjectCache())
>         cache->postNotification(root, AXObjectCache::AXLayoutComplete, true);
> #endif
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a526ab73ddffafa0cec6a30b4121285fb4be569f..18d0a7879f9e1e45ee40127690e29c7dfc30cda4 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
>+
>+        [GTK] accessibility/loading-iframe-sends-notification.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=98370
>+
>+        Reviewed by Chris Fleizach.
>+
>+        Added AXLayoutComplete for the GTK platform.
>+
>+        * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
>+        (axObjectEventListener): Added notification AXLayoutComplete for
>+        layout-complete signal.
>+
> 2013-09-10  VÃctor Manuel JÃ¡quez Leal  <vjaquez@igalia.com>
> 
>         Unreviewed. Add myself as a committer.
>diff --git a/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp b/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp
>index 73c7ec957a7d2dcfbb7b341b4896fb297943d87f..8d9ae01709443bbd57e635c4eb2d5905b0d720af 100644
>--- a/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp
>+++ b/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp
>@@ -106,6 +106,8 @@ static gboolean axObjectEventListener(GSignalInvocationHint *signalHint, guint n
>             notificationName = "CheckedStateChanged";
>         else if (!g_strcmp0(g_value_get_string(&paramValues[1]), "invalid-entry"))
>             notificationName = "AXInvalidStatusChanged";
>+        else if (!g_strcmp0(g_value_get_string(&paramValues[1]), "layout-complete"))
>+            notificationName = "AXLayoutComplete";
>     } else if (!g_strcmp0(signalQuery.signal_name, "focus-event")) {
>         signalName.set(g_strdup("focus-event"));
>         signalValue.set(g_strdup_printf("%d", g_value_get_boolean(&paramValues[1])));
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index dd9cda5cbf0fc2033d8cc848f39d8a5c58068676..b31b787fa3bc621beb917be335dab4c487382616 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
>+
>+        [GTK] accessibility/loading-iframe-sends-notification.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=98370
>+
>+        Reviewed by Chris Fleizach.
>+
>+        Changed the expectation of the loading iframe notification test in
>+        accessibility, which was failing before this fix on the GTK+
>+        platform.
>+
>+        * platform/gtk/TestExpectations: Changed the expectation of the loading
>+        iframe notification test in accessibility.
>+
> 2013-09-10  Mark Lam  <mark.lam@apple.com>
> 
>         Move LayoutTests/fast/js to LayoutTests/js.
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 680893dad2eb0a7b96168bdf81e7cbd503d8f2f2..049c00ab604ab9eeb9dcdb7acd1ed52f82629022 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -858,7 +858,6 @@ webkit.org/b/98359 accessibility/aria-text-role.html [ Failure ]
> webkit.org/b/98360 accessibility/aria-used-on-image-maps.html [ Failure ]
> webkit.org/b/98361 accessibility/button-press-action.html [ Failure ]
> webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
>-webkit.org/b/98370 accessibility/loading-iframe-sends-notification.html [ Failure ]
> webkit.org/b/98371 accessibility/loading-iframe-updates-axtree.html [ Failure ]
> webkit.org/b/98372 accessibility/onclick-handlers.html [ Failure ]
> webkit.org/b/98375 accessibility/secure-textfield-title-ui.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 98370: 211203 | 211209 | 211210 | 211213