Attachment 382100 Details for Bug 202859 – Patch

[patch] Patch

bug-202859-20191028134404.patch (text/plain), 3.32 KB, created by Chris Dumez on 2019-10-28 13:44:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-10-28 13:44:05 PDT

Size: 3.32 KB

patch

obsolete

>Subversion Revision: 251662
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 839f6155f2e18692f0d9eb9cac496180adfd9b0a..c8d0408f4931f792664dbe63828bc4a3a947a2be 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-10-28  Chris Dumez  <cdumez@apple.com>
>+
>+        <input type="range">.setAttribute("value") does not update the value
>+        https://bugs.webkit.org/show_bug.cgi?id=202859
>+        <rdar://problem/56204271>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure the position of the range input element's slider gets updated whenever
>+        the element's 'value' attribute changes.
>+
>+        No new tests, unskipped existing test.
>+
>+        * html/RangeInputType.cpp:
>+        (WebCore::RangeInputType::attributeChanged):
>+
> 2019-10-28  Alex Christensen  <achristensen@webkit.org>
> 
>         Remove unused NetworkProcessCreationParameters.urlSchemesRegisteredAsCanDisplayOnlyIfCanRequest
>diff --git a/Source/WebCore/html/RangeInputType.cpp b/Source/WebCore/html/RangeInputType.cpp
>index 1e0f8be83a07d3eca7b9c43e660eec047c61c1ff..85edb97bb350ce6e658942c4264476836e103b4a 100644
>--- a/Source/WebCore/html/RangeInputType.cpp
>+++ b/Source/WebCore/html/RangeInputType.cpp
>@@ -329,7 +329,7 @@ void RangeInputType::accessKeyAction(bool sendMouseEvents)
> void RangeInputType::attributeChanged(const QualifiedName& name)
> {
>     // FIXME: Don't we need to do this work for precisionAttr too?
>-    if (name == maxAttr || name == minAttr) {
>+    if (name == maxAttr || name == minAttr || name == valueAttr) {
>         // Sanitize the value.
>         if (auto* element = this->element()) {
>             if (element->hasDirtyValue())
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 47ef2bc1d4bbc30aa331bc92eb1942f5096bf61b..20fffefd327906b2205e8e3217e483a9d62f64af 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-10-28  Chris Dumez  <cdumez@apple.com>
>+
>+        <input type="range">.setAttribute("value") does not update the value
>+        https://bugs.webkit.org/show_bug.cgi?id=202859
>+        <rdar://problem/56204271>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Unskip ref test that is no longer failing.
>+
>+        * TestExpectations:
>+
> 2019-10-28  Chris Dumez  <cdumez@apple.com>
> 
>         Update html/semantics/forms WPT tests from upstream
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 7fc85945ec6479a47182f45e872eef7739ad6fcf..4ead8cce8b9fa553cde4a0039373c719fdc52f9d 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -3916,8 +3916,6 @@ webkit.org/b/203336 imported/w3c/web-platform-tests/css/css-values/lh-unit-002.h
> webkit.org/b/203337 imported/w3c/web-platform-tests/css/css-values/vh-support-atviewport.html [ ImageOnlyFailure ]
> webkit.org/b/203338 imported/w3c/web-platform-tests/css/css-values/vh_not_refreshing_on_chrome.html [ ImageOnlyFailure ]
> 
>-webkit.org/b/202859 imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-setattribute-value.html [ ImageOnlyFailure ]
>-
> # wpt css-position failures
> webkit.org/b/203445 [ Debug ] imported/w3c/web-platform-tests/css/css-position/position-absolute-container-dynamic-002.html [ Skip ]
> webkit.org/b/203445 [ Debug ] imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-005.html [ Skip ]

Actions: View | Formatted Diff | Diff

Attachments on bug 202859: 382100 | 382126 | 382182