Bug 101881

Summary: [Refactoring] Remove shadowPseudoId() and use setPseudo() in HTMLKeygenElement
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101171    
Attachments:
Description Flags
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-11-11 18:42:02 PST
We would like to remove shadowPseudoId, and use pseudo() instead.
Attachments
Patch (2.17 KB, patch)
2012-11-11 21:02 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2012-11-11 22:09 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-11 21:02:09 PST
Created attachment 173547 [details] Patch
Kent Tamura
Comment 2 2012-11-11 21:07:33 PST
Comment on attachment 173547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173547&action=review > Source/WebCore/html/HTMLKeygenElement.cpp:68 > + DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral)); Why don't you just put this into the constructor?
Shinya Kawanaka
Comment 3 2012-11-11 22:07:45 PST
(In reply to comment #2) > (From update of attachment 173547 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173547&action=review > > > Source/WebCore/html/HTMLKeygenElement.cpp:68 > > + DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral)); > > Why don't you just put this into the constructor? Ah, I'll do so.
Shinya Kawanaka
Comment 4 2012-11-11 22:09:17 PST
Created attachment 173554 [details] Patch
Kent Tamura
Comment 5 2012-11-11 22:10:56 PST
Comment on attachment 173554 [details] Patch Looks good
WebKit Review Bot
Comment 6 2012-11-11 22:35:53 PST
Comment on attachment 173554 [details] Patch Clearing flags on attachment: 173554 Committed r134189: <http://trac.webkit.org/changeset/134189>
WebKit Review Bot
Comment 7 2012-11-11 22:35:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.