Bug 102021

Summary: [chromium] Lazy image decoding without cache
Product: WebKit Reporter: Hin-Chung Lam <hclam>
Component: ImagesAssignee: Hin-Chung Lam <hclam>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, dglazkov, jamesr, nduca, nick, peter+ews, senorblanco, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102019, 102734    
Bug Blocks: 99785, 99790    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Hin-Chung Lam
Reported 2012-11-12 17:40:07 PST
The goal is to make ImageDecodingStore be a simple image cache and does nothing more. This is the second step to refactor ImageDecodingStore and ImageFrameGenerator. The change involves moving the code to actually decode and scale an image, the code will be moved from ImageDecodingStore to ImageFrameGenerator. There should be no new code in this change.
Attachments
Patch (13.19 KB, patch)
2012-11-13 13:15 PST, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Patch (22.07 KB, patch)
2012-11-19 03:05 PST, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Patch (21.19 KB, patch)
2012-11-19 03:07 PST, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Patch (21.22 KB, patch)
2012-11-19 11:47 PST, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.79 KB, patch)
2012-11-19 13:36 PST, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Hin-Chung Lam
Comment 1 2012-11-13 13:15:07 PST
Created attachment 173966 [details] Patch
Hin-Chung Lam
Comment 2 2012-11-13 13:16:53 PST
This is the second part of refactoring, i.e. to move image decoding from ImageDecodingStore into ImageFrameGenerator. There's no new logic implemented in this change. Pending on 102019 to review / land.
Hin-Chung Lam
Comment 3 2012-11-19 03:05:15 PST
Created attachment 174932 [details] Patch
Hin-Chung Lam
Comment 4 2012-11-19 03:07:55 PST
Created attachment 174934 [details] Patch
WebKit Review Bot
Comment 5 2012-11-19 03:16:02 PST
Comment on attachment 174934 [details] Patch Attachment 174934 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14916143
Peter Beverloo (cr-android ews)
Comment 6 2012-11-19 04:31:26 PST
Comment on attachment 174934 [details] Patch Attachment 174934 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14909184
Hin-Chung Lam
Comment 7 2012-11-19 11:47:45 PST
Created attachment 175014 [details] Patch
Hin-Chung Lam
Comment 8 2012-11-19 11:50:02 PST
This change is to make image decoding completely lazy without any caching. Next change I'm preparing is to make this lazy decoding thread-safe such that nduca@ can proceed impl-side painting and decoding.
Stephen White
Comment 9 2012-11-19 12:06:15 PST
Comment on attachment 175014 [details] Patch Looks good, bots willing. r=me
Hin-Chung Lam
Comment 10 2012-11-19 13:36:05 PST
Created attachment 175036 [details] Patch for landing
WebKit Review Bot
Comment 11 2012-11-19 14:20:47 PST
Comment on attachment 175036 [details] Patch for landing Clearing flags on attachment: 175036 Committed r135196: <http://trac.webkit.org/changeset/135196>
WebKit Review Bot
Comment 12 2012-11-19 14:20:52 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 13 2012-11-19 16:14:28 PST
Re-opened since this is blocked by bug 102734
Yury Semikhatsky
Comment 14 2012-11-19 22:34:55 PST
(In reply to comment #13) > Re-opened since this is blocked by bug 102734 Compiler error was fixed in http://trac.webkit.org/changeset/135253
Note You need to log in before you can comment on or make changes to this bug.