Bug 102072

Summary:

Clean up use of adjustWindowRect

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebCore Misc.

Assignee:

Kenneth Rohde Christiansen <kenneth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, japhet, mikhail.pozdnyakov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
New testing approach	none
Patch	none

Kenneth Rohde Christiansen

Reported 2012-11-13 05:13:53 PST

SSIA

Attachments
Patch (13.49 KB, patch) 2012-11-13 05:17 PST, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Patch (14.02 KB, patch) 2012-11-13 05:36 PST, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
New testing approach (14.14 KB, patch) 2012-11-13 14:33 PST, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Patch (14.90 KB, patch) 2012-11-14 02:42 PST, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Kenneth Rohde Christiansen

Comment 1 2012-11-13 05:17:25 PST

Created attachment 173874 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2012-11-13 05:36:17 PST

Created attachment 173878 [details] Patch

Mikhail Pozdnyakov

Comment 3 2012-11-13 06:25:17 PST

Comment on attachment 173878 [details] Patch looks good

Build Bot

Comment 4 2012-11-13 09:58:00 PST

Comment on attachment 173878 [details] Patch Attachment 173878 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14815661 New failing tests: fast/dom/Window/open-window-min-size.html

WebKit Review Bot

Comment 5 2012-11-13 09:59:49 PST

Comment on attachment 173878 [details] Patch Clearing flags on attachment: 173878 Committed r134434: <http://trac.webkit.org/changeset/134434>

WebKit Review Bot

Comment 6 2012-11-13 09:59:52 PST

All reviewed patches have been landed. Closing bug.

Dimitri Glazkov (Google)

Comment 7 2012-11-13 11:25:01 PST

Reverted r134434 for reason: The test that was added asserts in loader. Committed r134451: <http://trac.webkit.org/changeset/134451>

Dimitri Glazkov (Google)

Comment 8 2012-11-13 11:26:25 PST

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fdom%2FWindow%2Fopen-window-min-size.html Here's the ASSERT: crash log for DumpRenderTree (pid 25001): STDOUT: <empty> STDERR: ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url()) || !defersLoading() STDERR: third_party/WebKit/Source/WebCore/loader/MainResourceLoader.cpp(388) : virtual void WebCore::MainResourceLoader::didReceiveResponse(const WebCore::ResourceResponse&) STDERR: 1 0x7f998c67a871 STDERR: 2 0x7f998c690543 STDERR: 3 0x7f998bfdb573 STDERR: 4 0x7f9987534219 STDERR: 5 0x5edb4f STDERR: 6 0x5f4193 STDERR: 7 0x5f3b7e STDERR: 8 0x5f33c6 STDERR: 9 0x7f9988c2730d STDERR: 10 0x7f9988c6a0ad MessageLoop::RunTask(base::PendingTask const&) STDERR: 11 0x7f9988c6a1c8 MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) STDERR: 12 0x7f9988c6aa5d MessageLoop::DoWork() STDERR: 13 0x7f9988c0be36 base::MessagePumpGlib::RunWithDispatcher(base::MessagePump::Delegate*, base::MessagePumpDispatcher*) STDERR: 14 0x7f9988c0c216 base::MessagePumpGlib::Run(base::MessagePump::Delegate*) STDERR: 15 0x7f9988c69c9d MessageLoop::RunInternal() STDERR: 16 0x7f9988c69b54 MessageLoop::RunHandler() STDERR: 17 0x7f9988ca1212 base::RunLoop::Run() STDERR: 18 0x7f9988c69482 MessageLoop::Run() STDERR: 19 0x51db02 STDERR: 20 0x4b375a STDERR: 21 0x7f998b0ba118 STDERR: 22 0x7f998c6dae28 STDERR: 23 0x7f998c6fe1a0 STDERR: 24 0x7f998c255b81 STDERR: 25 0x7f99890b661a STDERR: 26 0x7f99890b1279 STDERR: 27 0x7f99890b124a STDERR: 28 0x12fc8ab0618e

Kenneth Rohde Christiansen

Comment 9 2012-11-13 14:33:35 PST

Created attachment 173991 [details] New testing approach

Gyuyoung Kim

Comment 10 2012-11-13 20:19:34 PST

Comment on attachment 173991 [details] New testing approach Looks fine.

Build Bot

Comment 11 2012-11-13 22:18:42 PST

Comment on attachment 173991 [details] New testing approach Attachment 173991 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14828310 New failing tests: fast/dom/Window/open-window-min-size.html

Kenneth Rohde Christiansen

Comment 12 2012-11-14 02:42:52 PST

Created attachment 174118 [details] Patch

Kenneth Rohde Christiansen

Comment 13 2012-11-14 02:44:56 PST

Working fine now locally on chromium --debug, skipping for mac.

WebKit Review Bot

Comment 14 2012-11-14 03:05:54 PST

Comment on attachment 174118 [details] Patch Clearing flags on attachment: 174118 Committed r134586: <http://trac.webkit.org/changeset/134586>

WebKit Review Bot

Comment 15 2012-11-14 03:06:00 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.