Bug 102731

Summary: [CSS Shaders] Do not clamp indirect array indices during CSS Shaders ANGLE validation pass
Product: WebKit Reporter: Max Vujovic <mvujovic>
Component: Layout and RenderingAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, dino, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71392    
Attachments:
Description Flags
Patch none

Max Vujovic
Reported 2012-11-19 16:09:43 PST
Right now, we validate all shaders with the compile flag SH_CLAMP_INDIRECT_ARRAY_BOUNDS in ANGLEWebKitBridge. This inserts a GLSL function "webgl_int_clamp" in validated CSS shaders. However, when validated CSS shaders pass through ANGLE again at the GC3D level, ANGLE rejects them because they use the "webgl_" restricted prefix. We should only pass the compile flag SH_CLAMP_INDIRECT_ARRAY_BOUNDS at the GC3D level. Patch coming up.
Attachments
Patch (8.93 KB, patch)
2012-11-19 16:44 PST, Max Vujovic 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Max Vujovic
Comment 1 2012-11-19 16:44:10 PST
Created attachment 175075 [details] Patch
Max Vujovic
Comment 2 2012-11-30 16:58:43 PST
Thanks for the review, Dean! I'll land this on Monday, so I can watch the build bots.
WebKit Review Bot
Comment 3 2012-12-03 12:57:01 PST
Comment on attachment 175075 [details] Patch Clearing flags on attachment: 175075 Committed r136430: <http://trac.webkit.org/changeset/136430>
WebKit Review Bot
Comment 4 2012-12-03 12:57:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.