Bug 103046

Summary:

[TexMap] Remove dependency of TextureMapperLayer on GraphicsLayerTextureMapper.

Product:

WebKit

Reporter:

Dongseong Hwang <dongseong.hwang>

Component:

Layout and Rendering

Assignee:

Dongseong Hwang <dongseong.hwang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

noam, philn, webkit.review.bot, xan.lopez, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

102994, 103171, 104640

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Dongseong Hwang

Reported 2012-11-22 03:06:22 PST

It is a preparation patch for Threaded Coordinated Graphics on WK1. We want to make TextureMapperLayer into an actor model. After making an actor model, GraphicsLayerTextureMapper and LayerTreeRenderer will communicate with TextureMapperLayer using message passing. In the first step, we want to hide GraphicsLayerTextureMapper from TextureMapperLayer. There are 2 kinds of dependencies of TextureMapperLayer in GraphicsLayerTextureMapper. 1. To query layer states 2. To paint layer contents In this patch, we removed the second dependency. Currently, TextureMapperLayer requests painting contents to GraphicsLayerTextureMapper in WK1 while Coordinated Graphics prepares the contents in LayerTreeRenderer. This patch makes WK1 prepare the contents in GraphicsLayerTextureMapper like LayerTreeRenderer. We will remove the first dependency in a follow-up patch.

Attachments
Patch (26.45 KB, patch) 2012-11-22 03:12 PST, Dongseong Hwang	no flags	Details Formatted Diff Diff
Patch (26.51 KB, patch) 2012-11-22 16:39 PST, Dongseong Hwang	no flags	Details Formatted Diff Diff
Patch (26.51 KB, patch) 2012-11-22 18:20 PST, Dongseong Hwang	no flags	Details Formatted Diff Diff
Patch (26.54 KB, patch) 2012-11-22 18:24 PST, Dongseong Hwang	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dongseong Hwang

Comment 1 2012-11-22 03:12:40 PST

Created attachment 175636 [details] Patch

EFL EWS Bot

Comment 2 2012-11-22 04:41:16 PST

Comment on attachment 175636 [details] Patch Attachment 175636 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14966333

Noam Rosenthal

Comment 3 2012-11-22 06:17:38 PST

Comment on attachment 175636 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175636&action=review Looks really good! Seems like it's missing some Timer.h includes though :) > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:57 > + , m_shouldManageBackingStore(true) m_hasOwnBackingStore > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:475 > + Empty line

Dongseong Hwang

Comment 4 2012-11-22 16:38:49 PST

(In reply to comment #3) > (From update of attachment 175636 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175636&action=review > > Looks really good! Seems like it's missing some Timer.h includes though :) Thanks for review! I just do as you said :) GraphicsLayerTextureMapper absolutely needs Timer.h, but it's interesting how only qt can build without Timer.h. > > > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:57 > > + , m_shouldManageBackingStore(true) > > m_hasOwnBackingStore Done > > > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:475 > > + > > Empty line Done

Dongseong Hwang

Comment 5 2012-11-22 16:39:36 PST

Created attachment 175715 [details] Patch

EFL EWS Bot

Comment 6 2012-11-22 16:44:01 PST

Comment on attachment 175715 [details] Patch Attachment 175715 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14964571

Dongseong Hwang

Comment 7 2012-11-22 18:20:12 PST

Created attachment 175722 [details] Patch

EFL EWS Bot

Comment 8 2012-11-22 18:23:42 PST

Comment on attachment 175722 [details] Patch Attachment 175722 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14967551