Bug 103615

Summary: Log to console when forms and popups are blocked by 'sandbox'.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101964    
Attachments:
Description Flags
Patch
none
Tests. none

Mike West
Reported 2012-11-29 01:16:19 PST
Continuing to skim through the sandbox flags we're currently not logging. This touches the two call sites in FrameLoader.cpp.
Attachments
Patch (9.74 KB, patch)
2012-11-29 01:19 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Tests. (11.31 KB, patch)
2012-11-29 13:17 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-11-29 01:19:56 PST
Created attachment 176673 [details] Patch
WebKit Review Bot
Comment 2 2012-11-29 11:58:15 PST
Comment on attachment 176673 [details] Patch Attachment 176673 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15054059 New failing tests: http/tests/security/no-popup-from-sandbox.html http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
Mike West
Comment 3 2012-11-29 13:17:35 PST
Created attachment 176799 [details] Tests.
Mike West
Comment 4 2012-12-04 01:41:36 PST
Friendly ping. :)
WebKit Review Bot
Comment 5 2012-12-04 10:35:23 PST
Comment on attachment 176799 [details] Tests. Clearing flags on attachment: 176799 Committed r136527: <http://trac.webkit.org/changeset/136527>
WebKit Review Bot
Comment 6 2012-12-04 10:35:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.