Bug 103810

Summary: CSP 1.1 tests are failing under GTK.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, philn, webkit.review.bot, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99064, 103652    
Attachments:
Description Flags
Patch
none
Patch none

Mike West
Reported 2012-12-01 00:30:42 PST
We just flipped the CSP_NEXT flag to be runtime enabled. I'm not sure how to make that work correctly under GTK, so I'll skip the tests for the moment.
Attachments
Patch (5.47 KB, patch)
2012-12-01 02:57 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (5.48 KB, patch)
2012-12-01 05:54 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-12-01 00:36:53 PST
Skipped in r136307. Adam, Zan, can one of you point me in the right direction for supporting this feature for non-Chromium ports? I'm happy to do the work, I just don't see anything obvious (nothing in Tools/DumpRenderTree/gtk seems to make use of runtime enabled anything...). Thanks!
Zan Dobersek
Comment 2 2012-12-01 01:57:44 PST
(In reply to comment #1) > Skipped in r136307. > > Adam, Zan, can one of you point me in the right direction for supporting this feature for non-Chromium ports? I'm happy to do the work, I just don't see anything obvious (nothing in Tools/DumpRenderTree/gtk seems to make use of runtime enabled anything...). > > Thanks! Non-Chromium ports usually enable runtime features through either the DumpRenderTreeSupport object, which presents a bridge of some sorts between DRT and WebCore, or by adding an appropriate setting to the port-specific API (WebKitWebSettings for GTK, QWebSettings for QT etc.). In case of a feature under development the runtime feature enablement is done through the DumpRenderTreeSupport (for GTK that's in Source/WebKit/gtk/WebCoreSupport). There is already similar work present there that you can orientate by, for instance enabling the Shadow DOM feature.
Mike West
Comment 3 2012-12-01 02:57:26 PST
Created attachment 177099 [details] Patch
Mike West
Comment 4 2012-12-01 02:58:22 PST
(In reply to comment #3) > Created an attachment (id=177099) [details] > Patch Thanks for the detailed explanation. The patch looks pretty straightforward. :)
Zan Dobersek
Comment 5 2012-12-01 05:48:50 PST
Comment on attachment 177099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177099&action=review > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:706 > + RuntimeEnabledFeatures::setExperimentalContentSecurityFeaturesEnabled(enabled); Oops, missing 'Policy' in there (that's why it doesn't compile), otherwise the patch is OK. Thanks!
Mike West
Comment 6 2012-12-01 05:52:34 PST
(In reply to comment #5) > (From update of attachment 177099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177099&action=review > > > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:706 > > + RuntimeEnabledFeatures::setExperimentalContentSecurityFeaturesEnabled(enabled); > > Oops, missing 'Policy' in there (that's why it doesn't compile), otherwise the patch is OK. Thanks! Ugh. I can't type. I'll spin a new patch in a moment. :)
Mike West
Comment 7 2012-12-01 05:54:26 PST
Created attachment 177104 [details] Patch
Mike West
Comment 8 2012-12-01 22:50:00 PST
Comment on attachment 177104 [details] Patch Thanks, Adam. :)
WebKit Review Bot
Comment 9 2012-12-02 04:41:10 PST
Comment on attachment 177104 [details] Patch Clearing flags on attachment: 177104 Committed r136339: <http://trac.webkit.org/changeset/136339>
WebKit Review Bot
Comment 10 2012-12-02 04:41:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.