Bug 104507

Summary: Factor node traversal into standalone functions
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, allan.jensen, apinheiro, cfleizach, cmarcelo, darin, dglazkov, dmazzoni, d-r, eric, fmalita, gtk-ews, gyuyoung.kim, haraken, japhet, jdiggs, kling, macpherson, menard, mifenton, morrita, ojan.autocc, pdr, peter+ews, philn, rakuco, rwlbuis, schenney, tkent, tonikitoo, webkit.review.bot, xan.lopez, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch2
webkit.review.bot: commit-queue-
patch3
eric: review+
patch4
eflews.bot: commit-queue-
patch5 none

Antti Koivisto
Reported 2012-12-09 22:06:35 PST
Node traversal functions are currently Node and ContainerNode members. Their implementations are scattered over multiple header and source files. These functions have no particular reason to be members as they don't require non-public access. Make them freestanding function instead and gather them together.
Attachments
patch (149.19 KB, patch)
2012-12-09 22:31 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch2 (139.51 KB, patch)
2012-12-09 22:48 PST, Antti Koivisto 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch3 (142.10 KB, patch)
2012-12-10 10:08 PST, Antti Koivisto 		eric: review+
DetailsFormatted DiffDiff
patch4 (142.15 KB, patch)
2012-12-10 10:39 PST, Antti Koivisto 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
patch5 (142.71 KB, patch)
2012-12-10 15:44 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-12-09 22:31:33 PST
Created attachment 178474 [details] patch
Antti Koivisto
Comment 2 2012-12-09 22:48:01 PST
Created attachment 178477 [details] patch2
WebKit Review Bot
Comment 3 2012-12-09 23:20:24 PST
Comment on attachment 178477 [details] patch2 Attachment 178477 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15219827
Peter Beverloo (cr-android ews)
Comment 4 2012-12-09 23:40:41 PST
Comment on attachment 178477 [details] patch2 Attachment 178477 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15230463
kov's GTK+ EWS bot
Comment 5 2012-12-10 00:52:44 PST
Comment on attachment 178477 [details] patch2 Attachment 178477 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15238361
EFL EWS Bot
Comment 6 2012-12-10 01:05:05 PST
Comment on attachment 178477 [details] patch2 Attachment 178477 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15249002
EFL EWS Bot
Comment 7 2012-12-10 01:11:52 PST
Comment on attachment 178477 [details] patch2 Attachment 178477 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15242176
Antti Koivisto
Comment 8 2012-12-10 10:08:46 PST
Created attachment 178582 [details] patch3
Eric Seidel (no email)
Comment 9 2012-12-10 10:13:59 PST
Comment on attachment 178582 [details] patch3 Seems like a great idea. Thank you. :)
Dimitri Glazkov (Google)
Comment 10 2012-12-10 10:17:46 PST
Morrita-san, this is relevant to work you're doing on bug 104332.
Antti Koivisto
Comment 11 2012-12-10 10:39:50 PST
Created attachment 178586 [details] patch4
EFL EWS Bot
Comment 12 2012-12-10 13:12:36 PST
Comment on attachment 178586 [details] patch4 Attachment 178586 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15227785
Antti Koivisto
Comment 13 2012-12-10 15:44:26 PST
Created attachment 178654 [details] patch5 Based on Darin's suggestion renamed nextSibling -> nextSkippingChildren
Antti Koivisto
Comment 14 2012-12-10 16:14:45 PST
http://trac.webkit.org/changeset/137221
Hajime Morrita
Comment 15 2012-12-10 16:43:51 PST
(In reply to comment #10) > Morrita-san, this is relevant to work you're doing on bug 104332. Yeah, I'm thinking about something like NodeRenderingTraversal for encapsulte enabling/disabling ShadowComposedTreeWalker.
Note You need to log in before you can comment on or make changes to this bug.