Bug 105819

Summary: [Qt] REGRESSION(r138517): It made 2 tests fail
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Mike West <mkwst>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: darin, gyuyoung.kim, hausmann, mkwst, ossy, rakuco, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79666, 105774    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-12-27 23:59:54 PST
- http/tests/security/cross-frame-access-put.html - http/tests/security/sandboxed-iframe-form-top.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html' from frame with URL 'http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html'. The frame attempting navigation of the top-level window is sandboxed, but the 'allow-top-navigation' flag is not set. + CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match. CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match. --- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/sandboxed-iframe-form-top-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/sandboxed-iframe-form-top-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate a navigation change for frame with URL http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html from frame with URL http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html. +CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/sandboxed-iframe-form-top.html' from frame with URL 'http://127.0.0.1:8000/security/resources/sandboxed-iframe-form-top.html'. The frame attempting navigation of the top-level window is sandboxed, but the 'allow-top-navigation' flag is not set. This tests passes if the sandboxed frame cannot navigate the top frame.
Attachments
Patch (3.12 KB, patch)
2012-12-28 07:45 PST, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-12-28 00:13:00 PST
Should just need a rebaseline. I'll take care of it this afternoon when I'm in front of a computer again.
Csaba Osztrogonác
Comment 2 2012-12-28 00:14:23 PST
I can't and I won't check and fix any bug/regression in my holiday, I can do only the fire-fighting, so I skipped these tests to paint the bots green and let the others fixing the bug - r138525. And please don't forget unskipping them with the proper fix.
Mike West
Comment 3 2012-12-28 07:39:41 PST
Actually, this looks like a duplicate of 85522. `sandboxed-iframe-form-top.html` isn't causing problems on other platforms only because it's skipped. :) Moving the expectations around, and I'll close this as a dupe.
Mike West
Comment 4 2012-12-28 07:45:24 PST
Created attachment 180874 [details] Patch
Mike West
Comment 5 2012-12-28 07:51:09 PST
Comment on attachment 180874 [details] Patch Failed to apply on gtk.
Mike West
Comment 6 2012-12-28 07:54:20 PST
Comment on attachment 180874 [details] Patch Hrm. Trying again, I think the GTK EWS bot is simply unhappy.
WebKit Review Bot
Comment 7 2012-12-28 08:10:16 PST
Comment on attachment 180874 [details] Patch Clearing flags on attachment: 180874 Committed r138535: <http://trac.webkit.org/changeset/138535>
WebKit Review Bot
Comment 8 2012-12-28 08:10:21 PST
All reviewed patches have been landed. Closing bug.
Mike West
Comment 9 2012-12-28 08:32:46 PST
*** This bug has been marked as a duplicate of bug 85522 ***
Note You need to log in before you can comment on or make changes to this bug.