Bug 107140

Summary: Wire BackgroundHTMLParser to HTMLDocumentParser
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: WebCore Misc.Assignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
none
Patch for landing none

Tony Gentilcore
Reported 2013-01-17 10:12:12 PST
Wire BackgroundHTMLParser to HTMLDocumentParser
Attachments
Patch (12.85 KB, patch)
2013-01-17 10:46 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.49 KB, patch)
2013-01-17 10:58 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2013-01-17 10:46:58 PST
Created attachment 183211 [details] Patch
Adam Barth
Comment 2 2013-01-17 10:53:43 PST
Comment on attachment 183211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183211&action=review > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:182 > - parser->didReceiveTokensFromBackgroundParser(delivery->tokens); > + parser->feedTokens(delivery->tokens); Can we keep the didReceiveTokensFromBackgroundParser name? It's much more descriptive than "feedTokens". > Source/WebCore/html/parser/HTMLDocumentParser.h:44 > +class BackgroundHTMLParser; I would probably put this forward declaration inside the ifdef.
Tony Gentilcore
Comment 3 2013-01-17 10:58:41 PST
Created attachment 183213 [details] Patch for landing
Tony Gentilcore
Comment 4 2013-01-17 11:00:00 PST
(In reply to comment #2) > (From update of attachment 183211 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183211&action=review > > > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:182 > > - parser->didReceiveTokensFromBackgroundParser(delivery->tokens); > > + parser->feedTokens(delivery->tokens); > > Can we keep the didReceiveTokensFromBackgroundParser name? It's much more descriptive than "feedTokens". Done. > > > Source/WebCore/html/parser/HTMLDocumentParser.h:44 > > +class BackgroundHTMLParser; > > I would probably put this forward declaration inside the ifdef. Actually it wasn't necessary at all. I removed it.
WebKit Review Bot
Comment 5 2013-01-17 11:53:33 PST
Comment on attachment 183213 [details] Patch for landing Clearing flags on attachment: 183213 Committed r140019: <http://trac.webkit.org/changeset/140019>
WebKit Review Bot
Comment 6 2013-01-17 11:53:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.