Bug 108164

Summary: Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer
Product: WebKit Reporter: Jae Hyun Park <jaepark>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, dongseong.hwang, noam, rniwa, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108149    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jae Hyun Park
Reported 2013-01-29 00:52:48 PST
LayerTreeRenderer should not depend on CoordinatedLayerTreeHostProxy so that it can be moved to WebCore.
Attachments
Patch (9.21 KB, patch)
2013-01-29 00:57 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (9.22 KB, patch)
2013-01-29 15:35 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (9.20 KB, patch)
2013-01-30 20:36 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jae Hyun Park
Comment 1 2013-01-29 00:57:27 PST
Created attachment 185192 [details] Patch
Build Bot
Comment 2 2013-01-29 08:53:46 PST
Comment on attachment 185192 [details] Patch Attachment 185192 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16201189 New failing tests: fast/workers/worker-document-leak.html
Caio Marcelo de Oliveira Filho
Comment 3 2013-01-29 12:00:52 PST
LGTM.
Jae Hyun Park
Comment 4 2013-01-29 15:35:16 PST
Created attachment 185322 [details] Patch
Jae Hyun Park
Comment 5 2013-01-29 15:36:09 PST
(In reply to comment #4) > Created an attachment (id=185322) [details] > Patch Rebased.
Noam Rosenthal
Comment 6 2013-01-29 23:17:40 PST
Comment on attachment 185322 [details] Patch LGTM, though a WK2 owner has to sign off.
Benjamin Poulain
Comment 7 2013-01-30 15:41:14 PST
Comment on attachment 185322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185322&action=review Okay from me given Noam already reviewed. > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:98 > + // LayerTreeRendererClient Methods Period. > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:98 > - // The painting thread must lock the main thread to use below two methods, because two methods access members that the main thread manages. See m_coordinatedLayerTreeHostProxy. > + // The painting thread must lock the main thread to use below two methods, because two methods access members that the main thread manages. See m_client. > // Currently, QQuickWebPage::updatePaintNode() locks the main thread before calling both methods. > void purgeGLResources(); > void setActive(bool); This is backward. You should not document weird thread consistency issues, you should encapsulate them.
Jae Hyun Park
Comment 8 2013-01-30 20:36:27 PST
Created attachment 185668 [details] Patch
WebKit Review Bot
Comment 9 2013-01-30 21:23:34 PST
Comment on attachment 185668 [details] Patch Clearing flags on attachment: 185668 Committed r141376: <http://trac.webkit.org/changeset/141376>
WebKit Review Bot
Comment 10 2013-01-30 21:23:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.