Bug 108634

Summary: [EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, benjamin, gyuyoung.kim, kling, ky0.choi, lucas.de.marchi, naginenis, rakuco, sam, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 106440    
Bug Blocks: 106752    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-02-01 06:59:37 PST
EWK2UnitTestBase.ewk_view_page_contents_get APi test sometimes fail due to a fragile check in the test. This should be fixed. [ RUN ] EWK2UnitTestBase.ewk_view_page_contents_get /home/buildslave-1/webkit-buildslave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:933: Failure Value of: strncmp(data + 359, lines, strlen(lines)) Actual: 1 Expected: 0
Attachments
Patch (3.05 KB, patch)
2013-02-01 07:10 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-02-01 07:10:18 PST
Created attachment 186037 [details] Patch
Sudarsana Nagineni (babu)
Comment 2 2013-02-01 07:24:21 PST
Comment on attachment 186037 [details] Patch LGTM
Gyuyoung Kim
Comment 3 2013-02-01 16:00:33 PST
Comment on attachment 186037 [details] Patch Looks fine.
Chris Dumez
Comment 4 2013-02-03 01:24:22 PST
Could someone please review this one? Our bots are currently red due to this API test failing.
WebKit Review Bot
Comment 5 2013-02-07 10:51:21 PST
Comment on attachment 186037 [details] Patch Clearing flags on attachment: 186037 Committed r142153: <http://trac.webkit.org/changeset/142153>
WebKit Review Bot
Comment 6 2013-02-07 10:51:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.