Bug 108736

Summary: FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs
Product: WebKit Reporter: Michael Nordman <michaeln>
Component: WebCore Misc.Assignee: Michael Nordman <michaeln>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108733, 108851    
Attachments:
Description Flags
api
none
Patch for landing none

Michael Nordman
Reported 2013-02-01 18:13:35 PST
FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs. This patch is the 1st in a series of changes that straddle webkit vs chromium repositories. 1) WK: Declare new virtual createSnapshotFile/didCreateSnapshotFile public api methods. 2) CR: Implement the new create method such that the didCreate method is invoked in response. see https://codereview.chromium.org/12084077/ 3) WK: Use the new create method and implement the new didCreate method. see https://codereview.chromium.org/12183004/ for a preview 3) CR: Cleanup the obsolete/deprecated blocks of code.
Attachments
api (5.08 KB, patch)
2013-02-01 18:26 PST, Michael Nordman 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.32 KB, patch)
2013-02-02 21:21 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Nordman
Comment 1 2013-02-01 18:26:21 PST
Created attachment 186200 [details] api
WebKit Review Bot
Comment 2 2013-02-01 18:28:35 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2013-02-02 20:43:29 PST
Comment on attachment 186200 [details] api Rejecting attachment 186200 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 186200, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16355229
Adam Barth
Comment 4 2013-02-02 21:20:25 PST
Comment on attachment 186200 [details] api View in context: https://bugs.webkit.org/attachment.cgi?id=186200&action=review > Source/WebKit/chromium/ChangeLog:7 > + https://bugs.webkit.org/show_bug.cgi?id=108736 Looks like this ChangeLog is missing the "Reviewed by NOBODY (OOPS!)." line
Adam Barth
Comment 5 2013-02-02 21:21:47 PST
Created attachment 186248 [details] Patch for landing
WebKit Review Bot
Comment 6 2013-02-02 22:14:25 PST
Comment on attachment 186248 [details] Patch for landing Clearing flags on attachment: 186248 Committed r141712: <http://trac.webkit.org/changeset/141712>
WebKit Review Bot
Comment 7 2013-02-02 22:14:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.