Bug 109588

Created attachment 187876 [details] Patch

Comment on attachment 187876 [details] Patch Attachment 187876 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16510287

Comment on attachment 187876 [details] Patch Attachment 187876 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16517258

Comment on attachment 187876 [details] Patch Attachment 187876 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16531132

Created attachment 198125 [details] Patch

Comment on attachment 198125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198125&action=review Is this supposed to be always disabled, and what happens to TextureMapperImageBuffer in this case? > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:587 > + layer->setShouldMapBackingStoreToContentsRect(false); Isn't it always false? > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:594 > +// layer->setShouldMapBackingStoreToContentsRect(true); Is that supposed to be commented out?

Comment on attachment 198125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198125&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:587 >> + layer->setShouldMapBackingStoreToContentsRect(false); > > Isn't it always false? See below >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:594 >> +// layer->setShouldMapBackingStoreToContentsRect(true); > > Is that supposed to be commented out? No, it's a debugging leftover...

Created attachment 198850 [details] Patch

Comment on attachment 198850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198850&action=review LGTM > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:124 > + if (m_state.solidColor.isValid() && !m_state.contentsRect.isEmpty() && m_state.solidColor.alpha()) { Unrelated optimization, isn't it? But I will let it slide.

(In reply to comment #9) > (From update of attachment 198850 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198850&action=review > > LGTM Thanks, I'll ask a WK2 owner to approve. > > > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:124 > > + if (m_state.solidColor.isValid() && !m_state.contentsRect.isEmpty() && m_state.solidColor.alpha()) { > > Unrelated optimization, isn't it? It isn't :) Now that we support pattern compositing, if this is not there, this code path would be triggered and the pattern would not be drawn.

Comment on attachment 198850 [details] Patch wk2r=me

The commit-queue encountered the following flaky tests while processing attachment 198850 [details]: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html bug 114209 (author: vsevik@chromium.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) svg/animations/smil-leak-elements.svg bug 114280 (authors: fmalita@chromium.org and timothy_horton@apple.com) svg/animations/smil-leak-dynamically-added-element-instances.svg bug 114281 (authors: fmalita@chromium.org and timothy_horton@apple.com) The commit-queue is continuing to process your patch.

Comment on attachment 198850 [details] Patch Clearing flags on attachment: 198850 Committed r148748: <http://trac.webkit.org/changeset/148748>

All reviewed patches have been landed. Closing bug.