Bug 109861

Summary: TokenPreloadScanner should be able to scan CompactHTMLTokens
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, eric, ojan.autocc, philn, rniwa, tonyg, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108027    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2013-02-14 14:15:20 PST
TokenPreloadScanner should be able to scan CompactHTMLTokens
Attachments
Patch (14.28 KB, patch)
2013-02-14 14:20 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.71 KB, patch)
2013-02-15 10:32 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-02-14 14:20:20 PST
Created attachment 188426 [details] Patch
Early Warning System Bot
Comment 2 2013-02-14 14:32:43 PST
Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16581513
Early Warning System Bot
Comment 3 2013-02-14 14:33:29 PST
Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16538801
Adam Barth
Comment 4 2013-02-14 14:38:14 PST
Probably needs moar ifdefs. :) I'd be interested in your review feedback, however. I'll get it to compile before landing.
Eric Seidel (no email)
Comment 5 2013-02-14 14:39:08 PST
Comment on attachment 188426 [details] Patch I'm entertained that you undid my processPossible refactoring. :)
Adam Barth
Comment 6 2013-02-14 14:49:09 PST
> I'm entertained that you undid my processPossible refactoring. :) Yeah, sorry about that. I liked it, but it didn't play well with the switch statement.
EFL EWS Bot
Comment 7 2013-02-14 16:23:55 PST
Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16538845
Build Bot
Comment 8 2013-02-14 20:30:15 PST
Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16537920
Build Bot
Comment 9 2013-02-15 05:08:59 PST
Comment on attachment 188426 [details] Patch Attachment 188426 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16593082
Eric Seidel (no email)
Comment 10 2013-02-15 07:35:06 PST
Comment on attachment 188426 [details] Patch OK. Ugly switch. :(
Adam Barth
Comment 11 2013-02-15 10:32:07 PST
Created attachment 188600 [details] Patch for landing
WebKit Review Bot
Comment 12 2013-02-15 10:58:23 PST
Comment on attachment 188600 [details] Patch for landing Rejecting attachment 188600 [details] from commit-queue. abarth@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Adam Barth
Comment 13 2013-02-15 11:03:09 PST
wat?
Adam Barth
Comment 14 2013-02-15 11:13:10 PST
Comment on attachment 188600 [details] Patch for landing Clearing flags on attachment: 188600 Committed r143020: <http://trac.webkit.org/changeset/143020>
Adam Barth
Comment 15 2013-02-15 11:13:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.