Bug 110433

Summary: The DFG backend's and OSR's decision to unbox a variable should be based on whether it's used in a typed context
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 110533, 110535, 110650, 112106    
Bug Blocks: 109388    
Attachments:
Description Flags
work in progress
none
it runs things
none
the patch oliver: review+

Filip Pizlo
Reported 2013-02-20 22:52:59 PST
I have no evidence that this doesn't work. I just think we can do better.
Attachments
work in progress (12.48 KB, patch)
2013-02-25 11:09 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it runs things (16.81 KB, patch)
2013-02-25 17:50 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (19.34 KB, patch)
2013-02-26 16:46 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-02-25 11:09:12 PST
Created attachment 190094 [details] work in progress
Filip Pizlo
Comment 2 2013-02-25 17:50:38 PST
Created attachment 190167 [details] it runs things Haven't seen what the perf impact is, yet. And I'm not yet sure that it's entirely correct.
Filip Pizlo
Comment 3 2013-02-26 16:46:34 PST
Created attachment 190392 [details] the patch
Mark Hahnenberg
Comment 4 2013-02-26 17:13:33 PST
Comment on attachment 190392 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=190392&action=review r=me too, fwiw > Source/JavaScriptCore/dfg/DFGCommon.h:225 > +bool setAndCheck(T& left, U right) checkAndSet?
Filip Pizlo
Comment 5 2013-02-26 17:13:54 PST
(In reply to comment #4) > (From update of attachment 190392 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190392&action=review > > r=me too, fwiw > > > Source/JavaScriptCore/dfg/DFGCommon.h:225 > > +bool setAndCheck(T& left, U right) > > checkAndSet? Yup, renamed!
Filip Pizlo
Comment 6 2013-02-26 17:47:33 PST
Landed in http://trac.webkit.org/changeset/144131
Note You need to log in before you can comment on or make changes to this bug.