Bug 110637

Summary: Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, japhet, ojan.autocc, tonyg, vsevik, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110724    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2013-02-22 13:30:25 PST
Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
Attachments
Patch (7.80 KB, patch)
2013-02-22 13:34 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.79 KB, patch)
2013-02-25 12:19 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-02-22 13:34:07 PST
Created attachment 189815 [details] Patch
Eric Seidel (no email)
Comment 2 2013-02-22 13:43:34 PST
Comment on attachment 189815 [details] Patch This is fine. We could be more sophisticated and just handle the first chunk on the main thread. :)
Adam Barth
Comment 3 2013-02-22 13:49:43 PST
That might be worth doing in general for loads since we'll get to the first byte faster.
WebKit Review Bot
Comment 4 2013-02-22 14:19:35 PST
Comment on attachment 189815 [details] Patch Clearing flags on attachment: 189815 Committed r143797: <http://trac.webkit.org/changeset/143797>
WebKit Review Bot
Comment 5 2013-02-22 14:19:39 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2013-02-24 23:07:58 PST
Re-opened since this is blocked by bug 110724
Vsevolod Vlasov
Comment 7 2013-02-25 02:22:00 PST
Downstream chromium content_browsertests BookmarkletTest.NonEmptyResult test was also broken by this patch. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=BookmarkletTest.NonEmptyResult
Adam Barth
Comment 8 2013-02-25 12:19:13 PST
Created attachment 190102 [details] Patch for landing
WebKit Review Bot
Comment 9 2013-02-25 18:38:09 PST
Comment on attachment 190102 [details] Patch for landing Clearing flags on attachment: 190102 Committed r144000: <http://trac.webkit.org/changeset/144000>
WebKit Review Bot
Comment 10 2013-02-25 18:38:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.