Bug 110916

Summary: IndexedDB: Add temporary diagnostic code to IDBRequest.result getter
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dcarney, dgrogan, esprehn+autocc, haraken, japhet, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105363    
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2013-02-26 15:25:29 PST
IndexedDB: Add temporary diagnostic code to IDBRequest.result getter
Attachments
Patch (5.61 KB, patch)
2013-02-26 15:28 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (6.11 KB, patch)
2013-02-26 16:03 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2013-02-26 15:28:01 PST
Created attachment 190374 [details] Patch
Joshua Bell
Comment 2 2013-02-26 15:28:56 PST
haraken@ - can you take a look?
Kentaro Hara
Comment 3 2013-02-26 15:40:07 PST
Comment on attachment 190374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190374&action=review > Source/WebCore/Modules/indexeddb/IDBRequest.idl:36 > + [Custom] readonly attribute IDBAny result This should be [V8Custom]. > Source/WebCore/bindings/v8/custom/V8IDBRequestCustom.cpp:55 > + V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "dummyAttrForDebugging", v8::String::New("foo")); Let's add a comment about why you added this code. Maybe you can also add: if (wrapper.IsString()) { ASSERT(wrapper->Utf8Length() >= 0); } If a wrapper is not sane, it will crash at wrapper->Utf8Length().
Joshua Bell
Comment 4 2013-02-26 16:03:03 PST
Created attachment 190383 [details] Patch
Kentaro Hara
Comment 5 2013-02-26 16:08:57 PST
Comment on attachment 190383 [details] Patch Thanks. I hope this change will give us a good hint for further debugging.
WebKit Review Bot
Comment 6 2013-02-26 16:47:53 PST
Comment on attachment 190383 [details] Patch Clearing flags on attachment: 190383 Committed r144125: <http://trac.webkit.org/changeset/144125>
WebKit Review Bot
Comment 7 2013-02-26 16:47:56 PST
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 8 2013-03-13 00:39:38 PDT
jsbell: Was the crash bug that we've been concerned about fixed by dcarney? If so, we might want to remove the temporary diagnostic hack that was introduced by this change.
Joshua Bell
Comment 9 2013-03-19 10:42:54 PDT
(In reply to comment #8) > jsbell: Was the crash bug that we've been concerned about fixed by dcarney? If so, we might want to remove the temporary diagnostic hack that was introduced by this change. I removed this code in http://wkrev.com/144813
Note You need to log in before you can comment on or make changes to this bug.