Bug 111918

Summary: [CSS Grid Layout] Handle spanning grid items over specified grid tracks
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 103314    
Attachments:
Description Flags
Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes.
none
Patch for landing none

Julien Chaffraix
Reported 2013-03-08 20:41:02 PST
The current code assumes that a grid item only spans one grid track in every direction. Now that we can parse multiple positions and properly resolve them, we can allow spanning grid items to be properly sized after their spanning grid areas.
Attachments
Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes. (8.96 KB, patch)
2013-03-08 20:51 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.93 KB, patch)
2013-03-11 11:48 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-03-08 20:51:51 PST
Created attachment 192332 [details] Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes.
Tony Chang
Comment 2 2013-03-11 10:14:58 PDT
Comment on attachment 192332 [details] Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes. View in context: https://bugs.webkit.org/attachment.cgi?id=192332&action=review > Source/WebCore/rendering/RenderGrid.cpp:750 > + // We don't support spanning with auto positions yet. Nit: Should this be a FIXME?
Julien Chaffraix
Comment 3 2013-03-11 11:44:30 PDT
Comment on attachment 192332 [details] Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes. View in context: https://bugs.webkit.org/attachment.cgi?id=192332&action=review >> Source/WebCore/rendering/RenderGrid.cpp:750 >> + // We don't support spanning with auto positions yet. > > Nit: Should this be a FIXME? Good point, there is also not a single bug I can't point to as it really depends how much of the <grid-line> grammar we support.
Julien Chaffraix
Comment 4 2013-03-11 11:48:29 PDT
Created attachment 192521 [details] Patch for landing
WebKit Review Bot
Comment 5 2013-03-11 12:10:05 PDT
Comment on attachment 192521 [details] Patch for landing Clearing flags on attachment: 192521 Committed r145378: <http://trac.webkit.org/changeset/145378>
WebKit Review Bot
Comment 6 2013-03-11 12:10:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.