Bug 112767

Summary: Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
Product: WebKit Reporter: Matt Falkenhagen <falken>
Component: Layout and RenderingAssignee: Matt Falkenhagen <falken>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, mifenton, morrita, ojan.autocc, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 112085    
Attachments:
Description Flags
Patch none

Matt Falkenhagen
Reported 2013-03-19 18:22:45 PDT
The calls were added in http://trac.webkit.org/changeset/86526. disabled() never returns true for these elements, so we don't have to consider disabled() in supportsFocus(), and can just use HTMLElement::supportsFocus. Since HTMLMeterElement and HTMLProgressElement no longer inherit from HTMLFormControlElement, we don't need to override supportsFocus() at all.
Attachments
Patch (4.72 KB, patch)
2013-03-19 18:30 PDT, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1 2013-03-19 18:30:56 PDT
Created attachment 193963 [details] Patch
Kent Tamura
Comment 2 2013-03-20 15:54:03 PDT
Comment on attachment 193963 [details] Patch ok
WebKit Review Bot
Comment 3 2013-03-20 17:12:00 PDT
Comment on attachment 193963 [details] Patch Clearing flags on attachment: 193963 Committed r146417: <http://trac.webkit.org/changeset/146417>
WebKit Review Bot
Comment 4 2013-03-20 17:12:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.