Bug 113827

Summary: Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113930    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

jochen
Reported 2013-04-02 14:43:15 PDT
Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
Attachments
Patch (2.29 KB, patch)
2013-04-02 14:43 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2013-04-02 14:52 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2013-04-02 15:00 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-04-02 14:43:30 PDT
Created attachment 196230 [details] Patch
jochen
Comment 2 2013-04-02 14:52:10 PDT
Created attachment 196231 [details] Patch
Benjamin Poulain
Comment 3 2013-04-02 14:54:49 PDT
Comment on attachment 196231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196231&action=review > LayoutTests/fast/loader/url-selected-user-gesture.html:19 > + if (testRunner.windowCount() == numWindows) > + testPassed('no new window opened'); > + else > + testFailed('new window was created'); > + } If you rename "numWindows" to -> "originalWindowCount" You can just have shoudlBe('testRunner.windowCount()', 'originalWindowCount');
jochen
Comment 4 2013-04-02 15:00:44 PDT
Created attachment 196233 [details] Patch
WebKit Review Bot
Comment 5 2013-04-02 15:49:47 PDT
Comment on attachment 196233 [details] Patch Clearing flags on attachment: 196233 Committed r147503: <http://trac.webkit.org/changeset/147503>
WebKit Review Bot
Comment 6 2013-04-02 15:49:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.