Bug 114346

Summary:

Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

WebCore Misc.

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

67400

Attachments:

Description	Flags
Patch	none

Patrick R. Gansterer

Reported 2013-04-10 03:33:16 PDT

Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute

Attachments
Patch (2.36 KB, patch) 2013-04-10 03:35 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2013-04-10 03:35:16 PDT

Created attachment 197237 [details] Patch

Geoffrey Garen

Comment 2 2013-04-10 08:46:08 PDT

Comment on attachment 197237 [details] Patch r=me

WebKit Commit Bot

Comment 3 2013-04-10 09:24:47 PDT

The commit-queue encountered the following flaky tests while processing attachment 197237 [details]: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html bug 114209 (author: vsevik@chromium.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) media/track/track-mode.html bug 114361 (author: annacc@chromium.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 4 2013-04-10 09:25:41 PDT

Comment on attachment 197237 [details] Patch Clearing flags on attachment: 197237 Committed r148100: <http://trac.webkit.org/changeset/148100>

WebKit Commit Bot

Comment 5 2013-04-10 09:25:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.