Bug 114750

Summary: [Qt][Mac] Remove obsolete workaround for debug builds
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: New BugsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte, vestbo, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110211    
Attachments:
Description Flags
Patch
none
Patch none

Andras Becsi
Reported 2013-04-17 11:01:17 PDT
[Qt][Mac] Remove obsolete workaround for debug builds
Attachments
Patch (1.87 KB, patch)
2013-04-17 11:02 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Patch (1.82 KB, patch)
2013-04-17 11:08 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2013-04-17 11:02:48 PDT
Created attachment 198585 [details] Patch
Andras Becsi
Comment 2 2013-04-17 11:08:00 PDT
Created attachment 198587 [details] Patch
Jocelyn Turcotte
Comment 3 2013-04-18 00:44:35 PDT
Comment on attachment 198587 [details] Patch If this is broken there is good chance that all references to BASE_TARGET are also broken.
Andras Becsi
Comment 4 2013-04-18 03:15:25 PDT
(In reply to comment #3) > (From update of attachment 198587 [details]) > If this is broken there is good chance that all references to BASE_TARGET are also broken. My understanding is that the BASE_TARGET hack only applies for framework builds of Qt, which do not have the version number in their name. (The corresponding issue was reported here https://bugreports.qt-project.org/browse/QTBUG-30466) This causes a problem for non-framework builds where we tried to support debug-only builds with this hack. My assumption is that this workaround was put in place to remove the "_debug" suffix and probably worked before the library split when there was no version number in the libraries.
Andras Becsi
Comment 5 2013-04-18 03:19:33 PDT
Btw, I tried both framework and non-framework builds with this, using build-webkit and simply qmake && make and both worked. The stable branch is also missing the BASE_TARGET hack from the widgets.pri, so I'm going to cherry-pick that from trunk.
Jocelyn Turcotte
Comment 6 2013-04-19 08:12:26 PDT
Personally I don't use the configuration covered by that code, so if Tor Arne and Zeno are good with it I think it's good.
Jocelyn Turcotte
Comment 7 2013-04-19 08:12:57 PDT
Comment on attachment 198587 [details] Patch r=me if you make sure they are OK with it.
Zeno Albisser
Comment 8 2013-04-19 09:42:37 PDT
(In reply to comment #7) > (From update of attachment 198587 [details]) > r=me if you make sure they are OK with it. Lgtm
Andras Becsi
Comment 9 2013-04-20 02:51:57 PDT
Comment on attachment 198587 [details] Patch Clearing flags on attachment: 198587 Committed r148789: <http://trac.webkit.org/changeset/148789>
Andras Becsi
Comment 10 2013-04-20 02:52:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.