Bug 115495

Created attachment 200251 [details] Patch

Comment on attachment 200251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200251&action=review The update to the tool seems good. But seems like some issues with the updated strings file. > Source/WebCore/English.lproj/localizedStrings.js:-623 > -localizedStrings["Filter"] = "Filter"; I still see this in ConsoleView.js. Was this a duplicate entry? ConsoleView.js 468: var filterSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Filter")); > Source/WebCore/English.lproj/localizedStrings.js:936 > +localizedStrings["Number of calls"] = "Self time"; This doesn't look right. "Number of calls" should be "Number of calls".

(In reply to comment #2) > (From update of attachment 200251 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200251&action=review > > The update to the tool seems good. But seems like some issues with the updated strings file. > > > Source/WebCore/English.lproj/localizedStrings.js:-623 > > -localizedStrings["Filter"] = "Filter"; > > I still see this in ConsoleView.js. Was this a duplicate entry? > Yes, It was a dulpicate entry. And I remove one of two "Filter". (205 : localizedStrings["Filter"] = "Filter";) > ConsoleView.js > 468: var filterSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Filter")); > > > Source/WebCore/English.lproj/localizedStrings.js:936 > > +localizedStrings["Number of calls"] = "Self time"; > > This doesn't look right. "Number of calls" should be "Number of calls". Oops, I will fix it.

Created attachment 200255 [details] Patch

Comment on attachment 200255 [details] Patch Looks good. r=me

The commit-queue encountered the following flaky tests while processing attachment 200255 [details]: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch.

Comment on attachment 200255 [details] Patch Clearing flags on attachment: 200255 Committed r149468: <http://trac.webkit.org/changeset/149468>

All reviewed patches have been landed. Closing bug.