Bug 116019

Summary: CLoop llint backend should not use the d8 register as scratch register
Product: WebKit Reporter: Peter Wang <PeterHWang>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, ossy, rgabor, rniwa, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
none
Patch
none
Patch none

Peter Wang
Reported 2013-05-13 02:43:19 PDT
Thanks to the patch for bug#114811, a strange crush of our port is fixed. And actually there is another d8 used as "scratch register" in "cloop.rb", although it's not used so far. And I've noticed of that "sg5.lee@samsung.com" first mentioned how to resolve it in bug#114495. I just open this bug to suggest to fix the reminding things.
Attachments
Patch (1.15 KB, patch)
2013-05-13 02:45 PDT, Peter Wang 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (525.43 KB, application/zip)
2013-05-13 15:54 PDT, Build Bot 		no flags
Details
Patch (1.18 KB, patch)
2013-05-23 20:58 PDT, Peter Wang 		no flags
DetailsFormatted DiffDiff
Patch (1.18 KB, patch)
2013-05-23 23:10 PDT, Peter Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Wang
Comment 1 2013-05-13 02:45:38 PDT
Created attachment 201539 [details] Patch
Peter Wang
Comment 2 2013-05-13 02:52:01 PDT
(In reply to comment #1) > Created an attachment (id=201539) [details] > Patch Just upload this patch to propose to fix the remaining part.
Csaba Osztrogonác
Comment 3 2013-05-13 03:28:49 PDT
LGTM, but it would be better if a JSC expert can review it.
Build Bot
Comment 4 2013-05-13 15:54:32 PDT
Comment on attachment 201539 [details] Patch Attachment 201539 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/467317 New failing tests: editing/style/5065910.html
Build Bot
Comment 5 2013-05-13 15:54:33 PDT
Created attachment 201641 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Csaba Osztrogonác
Comment 6 2013-05-23 08:50:09 PDT
ping?
Peter Wang
Comment 7 2013-05-23 20:58:22 PDT
Created attachment 202760 [details] Patch
Peter Wang
Comment 8 2013-05-23 21:03:52 PDT
(In reply to comment #6) > ping Sorry to keep waiting. It's weird. My local MAC build can pass the case mentioned as failed case in comment#4. I just re-upload patch to have a try again.
Charles Wei
Comment 9 2013-05-23 21:26:22 PDT
Comment on attachment 202760 [details] Patch Try to resubmit the patch since the author believes last regression is not related to this patch.
WebKit Commit Bot
Comment 10 2013-05-23 23:00:01 PDT
Comment on attachment 202760 [details] Patch Rejecting attachment 202760 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 202760, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Csaba Osztrogonac found in /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py. /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/682007
Peter Wang
Comment 11 2013-05-23 23:10:28 PDT
Created attachment 202769 [details] Patch
Charles Wei
Comment 12 2013-05-23 23:14:40 PDT
Comment on attachment 202769 [details] Patch resubmit after fixing the typo of the Reviewer.
WebKit Commit Bot
Comment 13 2013-05-23 23:54:59 PDT
The commit-queue encountered the following flaky tests while processing attachment 202769 [details]: svg/batik/text/textAnchor.svg bug 116285 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textEffect3.svg bug 116521 (authors: darin@apple.com and zimmermann@kde.org) media/event-queue-crash.html bug 114177 (author: shinyak@chromium.org) media/video-zoom.html bug 116704 (authors: fischman@chromium.org, jamesr@chromium.org, rniwa@webkit.org, and vrk@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 14 2013-05-23 23:56:11 PDT
Comment on attachment 202769 [details] Patch Clearing flags on attachment: 202769 Committed r150630: <http://trac.webkit.org/changeset/150630>
WebKit Commit Bot
Comment 15 2013-05-23 23:56:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.