Bug 117308

Summary: [CSS Shapes] Rename updateLineBoundariesForExclusions to updateLineBoundariesForShapes
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256    
Attachments:
Description Flags
proposed patch achicu: review+, achicu: commit-queue-

Zoltan Horvath
Reported 2013-06-06 10:33:04 PDT
We have a standalone specification for CSS Shapes now: ​http://dev.w3.org/csswg/css-shapes/ so this change renames updateLineBoundariesForExclusions to updateLineBoundariesForShapes.
Attachments
proposed patch (3.77 KB, patch)
2013-06-06 10:36 PDT, Zoltan Horvath 		achicu: review+
achicu: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-06-06 10:36:23 PDT
Created attachment 203949 [details] proposed patch
Alexandru Chiculita
Comment 2 2013-06-06 14:53:14 PDT
Comment on attachment 203949 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=203949&action=review > Source/WebCore/rendering/RenderBlock.h:1087 > + void updateLineBoundariesForShapes(ExclusionShapeInsideInfo*, LayoutUnit&, LineLayoutState&, bool&); nit: the name is a little confusing. what about updateShapeAndSegmentsForCurrentLine ?
Zoltan Horvath
Comment 3 2013-06-06 15:49:22 PDT
(In reply to comment #2) > nit: the name is a little confusing. what about updateShapeAndSegmentsForCurrentLine ? Thanks for the review! Updated and landed in: http://trac.webkit.org/changeset/151295
Note You need to log in before you can comment on or make changes to this bug.