Bug 117881

Summary:

[CSS Shapes][CSS Regions] Modify existing tests to test overflow also when padding is applied on the container

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

CSS

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

89256

Attachments:

Description	Flags
proposed patch	buildbot: commit-queue-
Archive of layout-test-results from APPLE-EWS-2 for win-future	none
updated patch after r152800	buildbot: commit-queue-
proposed patch	none

Zoltan Horvath

Reported 2013-06-21 10:36:55 PDT

Currently we don't test padding behavior, so I modified the existing tests to increase our test coverage.

Attachments
proposed patch (15.57 KB, patch) 2013-06-21 10:43 PDT, Zoltan Horvath	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from APPLE-EWS-2 for win-future (796.74 KB, application/zip) 2013-06-21 13:54 PDT, Build Bot	no flags	Details
updated patch after r152800 (15.90 KB, patch) 2013-07-17 14:18 PDT, Zoltan Horvath	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch (15.58 KB, patch) 2013-07-18 09:43 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2013-06-21 10:43:36 PDT

Created attachment 205197 [details] proposed patch

Build Bot

Comment 2 2013-06-21 13:54:30 PDT

Comment on attachment 205197 [details] proposed patch Attachment 205197 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/960205 New failing tests: fast/media/mq-transform-03.html fast/forms/search-event-delay.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html

Build Bot

Comment 3 2013-06-21 13:54:31 PDT

Created attachment 205213 [details] Archive of layout-test-results from APPLE-EWS-2 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-2 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Zoltan Horvath

Comment 4 2013-07-17 14:18:53 PDT

Created attachment 206912 [details] updated patch after r152800

Build Bot

Comment 5 2013-07-17 21:34:23 PDT

Comment on attachment 206912 [details] updated patch after r152800 Attachment 206912 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1099411

Zoltan Horvath

Comment 6 2013-07-18 09:43:01 PDT

Created attachment 206996 [details] proposed patch

Dave Hyatt

Comment 7 2013-07-19 10:17:49 PDT

Comment on attachment 206996 [details] proposed patch r=me

WebKit Commit Bot

Comment 8 2013-07-19 10:39:37 PDT

Comment on attachment 206996 [details] proposed patch Clearing flags on attachment: 206996 Committed r152904: <http://trac.webkit.org/changeset/152904>

WebKit Commit Bot

Comment 9 2013-07-19 10:39:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.