Bug 120086

Summary: REGRESSION (r154300): http/tests/security/cross-frame-access-getOwnPropertyDescriptor is failing or crashing on the bots
Product: WebKit Reporter: Tim Horton <thorton>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, barraclough, ggaren, ossy, rniwa
Priority: P2 Keywords: InRadar, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 119995    
Attachments:
Description Flags
Fix ggaren: review+

Tim Horton
Reported 2013-08-20 13:58:06 PDT
From rniwa, in https://bugs.webkit.org/show_bug.cgi?id=119995: It seems like this patch caused http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html to fail or crash: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-getOwnPropertyDescriptor.html
Attachments
Fix (35.48 KB, patch)
2013-08-20 17:04 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-08-20 14:08:43 PDT
Failing expectation in http://trac.webkit.org/changeset/154357
Geoffrey Garen
Comment 2 2013-08-20 16:49:36 PDT
<rdar://problem/14790912>
Gavin Barraclough
Comment 3 2013-08-20 17:04:08 PDT
Created attachment 209238 [details] Fix
Geoffrey Garen
Comment 4 2013-08-20 17:06:12 PDT
Comment on attachment 209238 [details] Fix r=me
Gavin Barraclough
Comment 5 2013-08-20 23:05:10 PDT
Committed revision 154379.
Alexey Proskuryakov
Comment 6 2013-08-20 23:36:34 PDT
Is this patch expected to address the crashing aspect too?
Ryosuke Niwa
Comment 7 2013-08-20 23:42:54 PDT
(In reply to comment #6) > Is this patch expected to address the crashing aspect too? The crash had been fixed in http://trac.webkit.org/changeset/154313. Sorry, I should have clarified that earlier.
Note You need to log in before you can comment on or make changes to this bug.