Bug 121534

Summary: Rename OperationInProgress to HeapOperation and move it out of Heap.h into its own header
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121074    
Attachments:
Description Flags
Patch
none
Patch ggaren: review+, buildbot: commit-queue-

Mark Hahnenberg
Reported 2013-09-17 21:01:44 PDT
OperationInProgress is a silly name. Many parts of the Heap would like to know what HeapOperation is currently underway, but since they are included in Heap.h, they can't directly reference HeapOperation if it lives in Heap.h. The simplest thing to do is to give HeapOperation its own header. While a bit overkill, it simplifies including it wherever its needed.
Attachments
Patch (13.06 KB, patch)
2013-09-17 21:03 PDT, Mark Hahnenberg
no flags
Patch (15.35 KB, patch)
2013-09-17 21:07 PDT, Mark Hahnenberg
ggaren: review+
buildbot: commit-queue-
Mark Hahnenberg
Comment 1 2013-09-17 21:03:24 PDT
Mark Hahnenberg
Comment 2 2013-09-17 21:07:45 PDT
Geoffrey Garen
Comment 3 2013-09-17 21:34:03 PDT
Comment on attachment 211970 [details] Patch r=me
Build Bot
Comment 4 2013-09-17 21:35:26 PDT
Build Bot
Comment 5 2013-09-17 21:51:15 PDT
Mark Hahnenberg
Comment 6 2013-09-18 10:26:03 PDT
Note You need to log in before you can comment on or make changes to this bug.