Bug 122334
| Summary: | [CSS Shapes] Optimize relayout when shape-outside changes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Bear Travis <betravis> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | bfulgham, zoltan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 98664 | ||
Bear Travis
The layout code can repeatedly remove a float from the block lists, which is costly. This should be consolidated or short circuited so the heavy lifting is only done once.
See RenderElement::styleWillChange, RenderBox::styleWillChange, and RenderBox::styleDidChange.
Also, are there cases where removing / adding / changing a shape would not require relayout, and should we optimize for these?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
This code has been significantly refactored since this improvement was proposed. There doesn't seem to be any action we can take here.