Bug 123023

Summary: [mips][arm EABI] Fix J_JITOperation_EAapJ call in JIT.
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kilvadyb, msaboff, ossy, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Fix J_JITOperation_EAapJ call for MIPS and ARM EABI. none

Julien Brianceau
Reported 2013-10-18 07:51:37 PDT
EABI_32BIT_DUMMY_ARG is not expected in the following function, the EncodedJSValue parameter is already aligned to even registers for MIPS and ARM EABI (in 3rd and 4th argument registers): ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(J_JITOperation_EAapJ operation, int dst, ArrayAllocationProfile* arg1, GPRReg arg2Tag, GPRReg arg2Payload) { setupArgumentsWithExecState(TrustedImmPtr(arg1), EABI_32BIT_DUMMY_ARG arg2Payload, arg2Tag); return appendCallWithExceptionCheckSetJSValueResult(operation, dst); }
Attachments
Fix J_JITOperation_EAapJ call for MIPS and ARM EABI. (1.37 KB, patch)
2013-10-18 07:55 PDT, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-10-18 07:55:35 PDT
Created attachment 214572 [details] Fix J_JITOperation_EAapJ call for MIPS and ARM EABI.
WebKit Commit Bot
Comment 2 2013-10-18 08:22:14 PDT
Comment on attachment 214572 [details] Fix J_JITOperation_EAapJ call for MIPS and ARM EABI. Clearing flags on attachment: 214572 Committed r157633: <http://trac.webkit.org/changeset/157633>
WebKit Commit Bot
Comment 3 2013-10-18 08:22:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.