Bug 123464

Summary: Node shouldn't be selected if it's not a draggable element and has -webkit-user-select: none set
Product: WebKit Reporter: Crystal Zhang <haizhang>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, ntim, staikos, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Crystal Zhang
Reported 2013-10-29 13:58:14 PDT
As the comment says, if it's a draggable element, then it should be allowed to be selected, so drag & drop action can be performed, if it's not, and has -webkit-user-select: none set, then it shouldn't be allowed.
Attachments
patch (2.49 KB, patch)
2013-10-29 14:10 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Crystal Zhang
Comment 1 2013-10-29 14:10:31 PDT
Created attachment 215425 [details] patch patch.
Crystal Zhang
Comment 2 2013-10-29 14:16:12 PDT
Add Antonio to cc list.
Crystal Zhang
Comment 3 2013-10-29 14:42:23 PDT
Comment on attachment 215425 [details] patch Need have a second thought.
Ahmad Saleem
Comment 4 2024-05-03 16:42:13 PDT
This patch was modifying this: https://searchfox.org/wubkat/rev/3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f/Source/WebCore/dom/Node.cpp#1288 - It seems blink did the change: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/node.cc;l=1654;drc=5180d4deb2bee0cc22d14ced5ac540e51135a2e5 ** Blink: // We allow selections to begin within |user-select: text/all| sub trees // but not if the element is draggable. if (style.UserDrag() != EUserDrag::kElement && (user_select == EUserSelect::kText || user_select == EUserSelect::kAll)) return true; ** WebKit: // We allow selections to begin within an element that has -webkit-user-select: none set, // but if the element is draggable then dragging should take priority over selection. if (style.userDrag() == UserDrag::Element && style.usedUserSelect() == UserSelect::None) return false; } __
Tim Nguyen (:ntim)
Comment 5 2025-05-30 16:25:00 PDT
*** This bug has been marked as a duplicate of bug 208682 ***
Note You need to log in before you can comment on or make changes to this bug.