Bug 128883

Summary: DFG::prepareOSREntry should be nice to the stack
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ddkilzer, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 130539    
Bug Blocks:    
Attachments:
Description Flags
work in progress
none
the patch oliver: review+

Filip Pizlo
Reported 2014-02-15 21:34:01 PST
Patch forthcoming.
Attachments
work in progress (5.70 KB, patch)
2014-02-15 21:34 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (14.25 KB, patch)
2014-02-16 14:54 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-15 21:34:35 PST
Created attachment 224315 [details] work in progress
Filip Pizlo
Comment 2 2014-02-16 14:54:54 PST
Created attachment 224324 [details] the patch
Filip Pizlo
Comment 3 2014-02-16 22:20:08 PST
Landed in http://trac.webkit.org/changeset/164205
David Kilzer (:ddkilzer)
Comment 4 2014-02-17 07:08:25 PST
Comment on attachment 224324 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=224324&action=review > Source/JavaScriptCore/dfg/DFGOSREntry.h:70 > +// Returns a pointer to a data buffer that the OSR entry thunk will recognize and > +// parse. If this returns null, it means Unfinished comment.
Note You need to log in before you can comment on or make changes to this bug.