Bug 132566

Summary: Web Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInspector UI
Product: WebKit Reporter: Radu Stavila <stavila>
Component: Web InspectorAssignee: Radu Stavila <stavila>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, syoichi, timothy, webkit-bug-importer
Priority: P2 Keywords: AdobeTracked, InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch none

Radu Stavila
Reported 2014-05-05 07:18:16 PDT
Add the regionOversetChange event to the iOS 7.0 WebInspector UI
Attachments
Patch (2.91 KB, patch)
2014-05-06 04:23 PDT, Radu Stavila 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-05-05 07:18:59 PDT
<rdar://problem/16811884>
Radu Stavila
Comment 2 2014-05-06 04:23:58 PDT
Created attachment 230898 [details] Patch
WebKit Commit Bot
Comment 3 2014-05-06 05:38:21 PDT
Comment on attachment 230898 [details] Patch Clearing flags on attachment: 230898 Committed r168355: <http://trac.webkit.org/changeset/168355>
WebKit Commit Bot
Comment 4 2014-05-06 05:38:24 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5 2014-05-06 10:07:38 PDT
Comment on attachment 230898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230898&action=review > Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json:2192 > + { > + "name": "regionOversetChanged", > + "parameters": [ > + { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow containing the regions whose regionOverset values changed." } > + ], > + "description": "Fires if any of the regionOverset values changed in a Named Flow's region chain." Does adding this to the iOS 7 version actually fix an issue for you inspecting an iOS 7 device? The reason this is not in iOS-7.0 was because it did not exist in iOS 7. This change is not correct, but it is harmless. I think we should back it out. Only InspectorInstrumentation::didUpdateRegionLayout existed in iOS 7, InspectorInstrumentation::didChangeRegionOverset came later and is not in any iOS 7 release, so this event will never happen.
Radu Stavila
Comment 6 2014-05-07 01:55:40 PDT
Hi Joe, My mistake, I was under the impression the regionOversetChange event made it into iOS7. I will remove it. And one more thing, I also removed the regionLayoutUpdate event from the entire codebase (including the iOS7 inspector). Should I also add that event back into the iOS7 inspector? (that event actually exists in iOS7)
Joseph Pecoraro
Comment 7 2014-05-07 10:10:10 PDT
(In reply to comment #6) > My mistake, I was under the impression the regionOversetChange event made it into iOS7. Maybe the DOM event existed but the WebInspector hook for the event did not exist. > And one more thing, I also removed the regionLayoutUpdate event from the entire codebase (including the iOS7 inspector). Could you point me to the change you made? I can work back from there to see if it was good or not.
Radu Stavila
Comment 8 2014-05-07 13:42:26 PDT
https://bugs.webkit.org/show_bug.cgi?id=132564
Joseph Pecoraro
Comment 9 2014-05-08 10:34:18 PDT
(In reply to comment #8) > https://bugs.webkit.org/show_bug.cgi?id=132564 Thanks for the pointer. Yeah, it looks like we should leave in the bits for handling "regionLayoutUpdate" in the frontend for backwards compatibility and the best debugging experience for iOS 7. More comments in that bug.
Radu Stavila
Comment 10 2014-05-09 01:44:18 PDT
Created https://bugs.webkit.org/show_bug.cgi?id=132731
Note You need to log in before you can comment on or make changes to this bug.