Bug 139731

Summary: Purge PassRefPtr from Frame.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+
Patch for landing none

Andreas Kling
Reported 2014-12-17 09:22:27 PST
Yep.
Attachments
Patch (15.17 KB, patch)
2014-12-17 09:25 PST, Andreas Kling 		andersca: review+
DetailsFormatted DiffDiff
Patch for landing (15.19 KB, patch)
2014-12-17 09:36 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-12-17 09:25:11 PST
Created attachment 243438 [details] Patch
Anders Carlsson
Comment 2 2014-12-17 09:27:51 PST
Comment on attachment 243438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243438&action=review > Source/WebCore/page/Frame.cpp:210 > ASSERT(page); > ASSERT(client); Looks like these would be good candidates for turning into references. > Source/WebKit/mac/WebView/WebFrame.mm:324 > + Ref<Frame> coreFrame(Frame::create(page, ownerElement, new WebFrameLoaderClient(frame))); auto coreFrame = > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:126 > + Ref<Frame> coreFrame(Frame::create(page->corePage(), ownerElement, frame->m_frameLoaderClient.get())); auto coreFrame =
Andreas Kling
Comment 3 2014-12-17 09:36:43 PST
Created attachment 243439 [details] Patch for landing
WebKit Commit Bot
Comment 4 2014-12-17 10:22:02 PST
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2014-12-17 10:22:06 PST
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2014-12-17 11:02:49 PST
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2014-12-17 11:02:52 PST
The commit-queue encountered the following flaky tests while processing attachment 243439 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2014-12-17 11:38:35 PST
Comment on attachment 243439 [details] Patch for landing Clearing flags on attachment: 243439 Committed r177450: <http://trac.webkit.org/changeset/177450>
WebKit Commit Bot
Comment 9 2014-12-17 11:38:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.