Bug 144144

Summary: [CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspos boxes as definite
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2015-04-24 02:49:00 PDT
Per spec (http://dev.w3.org/csswg/css-sizing-3/#definite): "Additionally, the size of the containing block of an absolutely positioned element is always definite with respect to that element." If height is auto, we're ignoring this condition. Related Blink issue (where this was detected on flexbox first): https://codereview.chromium.org/1081433005/
Attachments
Patch (5.27 KB, patch)
2015-04-24 02:59 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2015-04-24 02:59:52 PDT
Created attachment 251545 [details] Patch
WebKit Commit Bot
Comment 2 2015-04-26 22:41:09 PDT
Comment on attachment 251545 [details] Patch Clearing flags on attachment: 251545 Committed r183385: <http://trac.webkit.org/changeset/183385>
WebKit Commit Bot
Comment 3 2015-04-26 22:41:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.