Bug 148913

Summary: Add initial support for doubles in WebAssembly
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, saam, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146064, 148945    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Sukolsak Sakshuwong
Reported 2015-09-06 12:57:28 PDT
Implement the ConstantPoolIndex, Immediate, and GetLocal instructions in WebAssembly.
Attachments
Patch (15.39 KB, patch)
2015-09-06 13:02 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (15.56 KB, patch)
2015-09-06 13:11 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (18.27 KB, patch)
2015-09-07 02:03 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.25 KB, patch)
2015-09-07 11:22 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-09-06 13:02:42 PDT
Created attachment 260712 [details] Patch
Sukolsak Sakshuwong
Comment 2 2015-09-06 13:11:35 PDT
Created attachment 260714 [details] Patch
Sukolsak Sakshuwong
Comment 3 2015-09-07 02:03:09 PDT
Created attachment 260731 [details] Patch
Filip Pizlo
Comment 4 2015-09-07 10:02:14 PDT
Comment on attachment 260731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260731&action=review > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:235 > +#if CPU(X86_64) || CPU(ARM64) We should use some combined condition that means 64-bit. Usually in JSC we use JSVALUE64 as such a condition.
Sukolsak Sakshuwong
Comment 5 2015-09-07 11:22:52 PDT
Created attachment 260743 [details] Patch for landing
Sukolsak Sakshuwong
Comment 6 2015-09-07 11:23:31 PDT
(In reply to comment #4) > Comment on attachment 260731 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260731&action=review > > > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:235 > > +#if CPU(X86_64) || CPU(ARM64) > > We should use some combined condition that means 64-bit. Usually in JSC we > use JSVALUE64 as such a condition. Thanks. Fixed.
WebKit Commit Bot
Comment 7 2015-09-08 10:39:44 PDT
Comment on attachment 260743 [details] Patch for landing Clearing flags on attachment: 260743 Committed r189494: <http://trac.webkit.org/changeset/189494>
WebKit Commit Bot
Comment 8 2015-09-08 10:39:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.