Bug 149102

Summary:

Implement the arithmetic instructions for floats in WebAssembly

Product:

WebKit

Reporter:

Sukolsak Sakshuwong <sukolsak>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, fpizlo, ggaren, mark.lam, saam, sukolsak, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

146064

Attachments:

Description	Flags
Patch	none

Sukolsak Sakshuwong

Reported 2015-09-13 01:26:14 PDT

Implement the arithmetic instructions for floats (float32) in WebAssembly.

Attachments
Patch (16.06 KB, patch) 2015-09-14 00:10 PDT, Sukolsak Sakshuwong	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sukolsak Sakshuwong

Comment 1 2015-09-14 00:10:32 PDT

Created attachment 261106 [details] Patch

WebKit Commit Bot

Comment 2 2015-09-14 00:13:31 PDT

Attachment 261106 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:844: JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 3 2015-09-14 10:42:04 PDT

Comment on attachment 261106 [details] Patch These conversions are pretty expensive. Why not just do the math as float?

Sukolsak Sakshuwong

Comment 4 2015-09-14 11:19:56 PDT

Thanks for the review. (In reply to comment #3) > Comment on attachment 261106 [details] > Patch > > These conversions are pretty expensive. Why not just do the math as float? Our macro assembler currently doesn't have any float arithmetic instructions. I could add them for x86, x86-64, and ARM. But I am not sure how to add and test them on MIPS and SH4. Is it OK if I just add them for x86, x86-64, and ARM and do something like #if CPU(X86) || CPU(X86_64) m_assembler.addsd_rr(...); #elif CPU(ARM) || CPU(ARM64) m_assembler....(...); #else convertFloatToDouble(FPRInfo::fpRegT0, FPRInfo::fpRegT0); addDouble(FPRInfo::fpRegT1, FPRInfo::fpRegT0); convertDoubleToFloat(FPRInfo::fpRegT0, FPRInfo::fpRegT0); #endif ?

WebKit Commit Bot

Comment 5 2015-09-14 11:30:21 PDT

Comment on attachment 261106 [details] Patch Clearing flags on attachment: 261106 Committed r189744: <http://trac.webkit.org/changeset/189744>

WebKit Commit Bot

Comment 6 2015-09-14 11:30:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.