Bug 149620

Summary: Fix the ARM build after r190192
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, mmaxfield, ossy
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645, 148413    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
darin: review+
patch for landing none

Csaba Osztrogonác
Reported 2015-09-29 03:14:02 PDT
https://trac.webkit.org/changeset/190192 broke the build on ARM Linux: ../../Source/WebCore/platform/graphics/FontFeatureSettings.h: In static member function âstatic void WebCore::FontFeatureTagHashTraits::constructDeletedValue(WebCore::FontFeatureTag&)â: ../../Source/WebCore/platform/graphics/FontFeatureSettings.h:50:134: error: narrowing conversion of -1 from int to char inside { } [-Werror=narrowing] static void constructDeletedValue(FontFeatureTag& slot) { new (NotNull, std::addressof(slot)) FontFeatureTag({{ -1, -1, -1, -1 }}); } The root of the problem is that char is unsigned on ARM.
Attachments
Patch (1.52 KB, patch)
2015-09-29 03:16 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2015-09-29 03:59 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2015-09-29 04:04 PDT, Csaba Osztrogonác 		darin: review+
DetailsFormatted DiffDiff
patch for landing (1.85 KB, patch)
2015-10-01 03:38 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-09-29 03:16:16 PDT
Created attachment 262057 [details] Patch
Csaba Osztrogonác
Comment 2 2015-09-29 03:59:52 PDT
Created attachment 262060 [details] Patch
Csaba Osztrogonác
Comment 3 2015-09-29 04:04:44 PDT
Created attachment 262061 [details] Patch
Darin Adler
Comment 4 2015-09-29 09:34:14 PDT
Comment on attachment 262061 [details] Patch A little messy; would be nice to have a named constant for static_cast<char>(0xFF) to avoid repeating it so many times. But seems fine.
Csaba Osztrogonác
Comment 5 2015-10-01 03:38:45 PDT
Created attachment 262245 [details] patch for landing
WebKit Commit Bot
Comment 6 2015-10-01 05:36:05 PDT
Comment on attachment 262245 [details] patch for landing Clearing flags on attachment: 262245 Committed r190402: <http://trac.webkit.org/changeset/190402>
Note You need to log in before you can comment on or make changes to this bug.