Bug 150410

Summary:

Web Inspector: Details sidebar section divider lines are missing on 2x devices

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

bburg, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Bug Depends on:

150383

Bug Blocks:

Attachments:

Description	Flags
Screenshot	none
1x Display Screenshot	none
2x Display Screenshot	none
[Image] Fixed	none

Timothy Hatcher

Reported 2015-10-21 12:53:12 PDT

Created attachment 263717 [details] Screenshot The divider lines are missing on my retina display, but appear when I drag the window to my 1x display.

Attachments
Screenshot (77.74 KB, image/png) 2015-10-21 12:53 PDT, Timothy Hatcher	no flags	Details
1x Display Screenshot (77.74 KB, image/png) 2015-10-21 12:53 PDT, Timothy Hatcher	no flags	Details
2x Display Screenshot (249.15 KB, image/png) 2015-10-21 12:54 PDT, Timothy Hatcher	no flags	Details
[Image] Fixed (52.18 KB, image/png) 2016-03-25 22:52 PDT, Nikita Vasilyev	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2015-10-21 12:53:40 PDT

Created attachment 263718 [details] 1x Display Screenshot

Radar WebKit Bug Importer

Comment 2 2015-10-21 12:54:05 PDT

<rdar://problem/23206436>

Timothy Hatcher

Comment 3 2015-10-21 12:54:13 PDT

Created attachment 263719 [details] 2x Display Screenshot

Devin Rousso

Comment 4 2015-10-21 14:35:24 PDT

In my opinion, I don't actually think that the lines are necessary. The change in the background color and additional padding (not a lot of it though) make it clear to me that they are different sections.

Nikita Vasilyev

Comment 5 2016-01-29 22:01:28 PST

This is because WebKit doesn't support subpixel values for `display: table-*` :( .details-section > .content > .group { display: table-row-group; ... } I wonder if this could be fixed in WebKit.

Nikita Vasilyev

Comment 6 2016-01-29 22:03:28 PST

(In reply to comment #4) > In my opinion, I don't actually think that the lines are necessary. The > change in the background color and additional padding (not a lot of it > though) make it clear to me that they are different sections. I also think the background color change is enough. There are already too many horizontal lines there.

Timothy Hatcher

Comment 7 2016-02-19 11:15:17 PST

We should revert the half-pixel CSS rules on the table cells until the WebKit bug is fixed.

Nikita Vasilyev

Comment 8 2016-03-25 22:52:03 PDT

Created attachment 274979 [details] [Image] Fixed (In reply to comment #7) > We should revert the half-pixel CSS rules on the table cells until the > WebKit bug is fixed. The WebKit bug (bug 150383) has been fixed.

Note You need to log in before you can comment on or make changes to this bug.