Bug 150614

Summary: Modern IDB: Support IDBDatabase.transaction() (and transaction scheduling in general)
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, rniwa
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1
none
Patch v2
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch v3 - Wild attempt at landable patch before I go home.
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
Patch v4 none

Brady Eidson
Reported 2015-10-27 17:13:45 PDT
Modern IDB: Support IDBDatabase.transaction() (and transaction scheduling in general)
Attachments
Patch v1 (88.48 KB, patch)
2015-10-28 15:21 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 (88.47 KB, patch)
2015-10-28 15:26 PDT, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (855.11 KB, application/zip)
2015-10-28 15:56 PDT, Build Bot 		no flags
Details
Patch v3 - Wild attempt at landable patch before I go home. (99.04 KB, patch)
2015-10-28 17:05 PDT, Brady Eidson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (677.48 KB, application/zip)
2015-10-28 18:27 PDT, Build Bot 		no flags
Details
Patch v4 (99.05 KB, patch)
2015-10-28 19:46 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-10-28 15:21:04 PDT
Created attachment 264254 [details] Patch v1
WebKit Commit Bot
Comment 2 2015-10-28 15:24:04 PDT
Attachment 264254 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:524: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2015-10-28 15:26:52 PDT
Created attachment 264255 [details] Patch v2
WebKit Commit Bot
Comment 4 2015-10-28 15:29:10 PDT
Attachment 264255 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:524: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 5 2015-10-28 15:56:25 PDT
Comment on attachment 264255 [details] Patch v2 Attachment 264255 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/350329 New failing tests: imported/w3c/indexeddb/idbdatabase_transaction5.htm
Build Bot
Comment 6 2015-10-28 15:56:28 PDT
Created attachment 264260 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Alex Christensen
Comment 7 2015-10-28 16:32:13 PDT
Comment on attachment 264255 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=264255&action=review Add a test that makes a spinning read-only transaction, another read-only transaction that stops the first one from spinning once it is finished, then a third read-write transaction that has to wait for both transactions to complete before starting. r=me once these tests are added. > Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:137 > + if (m_closePending) { Test this. > Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:142 > + if (objectStores.isEmpty()) { test this. > Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:148 > + IndexedDB::TransactionMode mode = IDBTransaction::stringToMode(modeString, ec); > + if (ec) test this. > Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:151 > + if (mode != IndexedDB::TransactionMode::ReadOnly && mode != IndexedDB::TransactionMode::ReadWrite) { test this. > Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:156 > + if (m_versionChangeTransaction) { test this. > Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:164 > + for (auto& objectStoreName : objectStores) { > + if (m_info.hasObjectStore(objectStoreName)) > + continue; > + ec = NOT_FOUND_ERR; test this. > Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp:40 > + IDBTransactionInfo result((IDBResourceIdentifier(connection))); That's a lot of parentheses. > Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp:49 > IDBTransactionInfo result((IDBResourceIdentifier(connection))); Here, too > Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp:101 > + scope.append(scopeArg.toString(&exec)->value(&exec)); can toString fail?
Brady Eidson
Comment 8 2015-10-28 17:05:40 PDT
Created attachment 264269 [details] Patch v3 - Wild attempt at landable patch before I go home.
WebKit Commit Bot
Comment 9 2015-10-28 17:07:04 PDT
Attachment 264269 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:524: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 10 2015-10-28 18:27:46 PDT
Comment on attachment 264269 [details] Patch v3 - Wild attempt at landable patch before I go home. Attachment 264269 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/350925 New failing tests: imported/w3c/indexeddb/idbdatabase_transaction5.htm
Build Bot
Comment 11 2015-10-28 18:27:48 PDT
Created attachment 264282 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Brady Eidson
Comment 12 2015-10-28 19:46:02 PDT
Created attachment 264291 [details] Patch v4
WebKit Commit Bot
Comment 13 2015-10-28 19:48:05 PDT
Attachment 264291 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:524: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 14 2015-10-28 23:16:50 PDT
Comment on attachment 264291 [details] Patch v4 Clearing flags on attachment: 264291 Committed r191722: <http://trac.webkit.org/changeset/191722>
WebKit Commit Bot
Comment 15 2015-10-28 23:16:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.