Bug 150831

Summary: B3::Stackmap should be a superclass of B3::PatchpointValue and B3::CheckValue rather than being one of their members
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
it's a start
none
more
none
the patch benjamin: review+

Filip Pizlo
Reported 2015-11-02 20:35:34 PST
This will simplify things a lot.
Attachments
it's a start (9.57 KB, patch)
2015-11-02 20:36 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (54.79 KB, patch)
2015-11-03 11:06 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (67.76 KB, patch)
2015-11-03 11:33 PST, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-02 20:36:37 PST
Created attachment 264659 [details] it's a start
Filip Pizlo
Comment 2 2015-11-03 11:06:38 PST
Created attachment 264700 [details] more Of course it doesn't compile yet.
Filip Pizlo
Comment 3 2015-11-03 11:33:22 PST
Created attachment 264703 [details] the patch
WebKit Commit Bot
Comment 4 2015-11-03 11:36:16 PST
Attachment 264703 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:68: The parameter name "comma" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/b3/testb3.cpp:1214: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 5 2015-11-03 15:20:52 PST
Comment on attachment 264703 [details] the patch rs=me
Filip Pizlo
Comment 6 2015-11-03 16:14:39 PST
Landed in http://trac.webkit.org/changeset/191993
Note You need to log in before you can comment on or make changes to this bug.