Bug 151682

Summary: CTTE autogenerated bindings code
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, ljaehun.lim, nikos.andronikos, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Anders Carlsson
Reported 2015-11-30 16:17:55 PST
CTTE autogenerated bindings code
Attachments
Patch (21.87 KB, patch)
2015-11-30 16:24 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (25.49 KB, patch)
2015-11-30 17:02 PST, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-11-30 16:24:06 PST
Created attachment 266297 [details] Patch
Anders Carlsson
Comment 2 2015-11-30 17:02:08 PST
Created attachment 266303 [details] Patch
Darin Adler
Comment 3 2015-11-30 17:31:44 PST
Comment on attachment 266303 [details] Patch There is so much more of this to be done in CodeGeneratorJS.pm, such as passing ExecState as a reference to most helpers.
Anders Carlsson
Comment 4 2015-11-30 18:14:07 PST
Committed r192849: <http://trac.webkit.org/changeset/192849>
Csaba Osztrogonác
Comment 5 2015-12-01 00:20:03 PST
Just to document: It broke the EFL build (not in WebKit2 code!) Unfortunately EWS didn't process this patch, because an other Apple employee broke the build previously against the red EWS bubble. And the fix landed in https://trac.webkit.org/changeset/192860
Csaba Osztrogonác
Comment 6 2015-12-01 00:21:26 PST
And it broke the GTK build too as the EWS noticed it.
Csaba Osztrogonác
Comment 7 2015-12-01 01:59:36 PST
(In reply to comment #6) > And it broke the GTK build too as the EWS noticed it. just to document, fix landed in https://trac.webkit.org/changeset/192872
Nikos Andronikos
Comment 8 2015-12-01 21:23:46 PST
Also to document: This is causing the following type of error in the generated Objective-C code for partial interfaces: webkit/WebKitBuild/Debug/DerivedSources/WebCore/DOMDocument.mm:443:65: error: non-const lvalue reference to type 'WebCore::Document' cannot bind to a temporary of type 'WebCore::Document *' return kit(WTF::getPtr(WebCore::DocumentAnimation::timeline(IMPL))); ^~~~ webkit/WebKitBuild/Debug/DerivedSources/WebCore/DOMDocument.mm:106:14: note: expanded from macro 'IMPL' #define IMPL static_cast<WebCore::Document*>(reinterpret_cast<WebCore::Node*>(_internal)) See bug 151739 for patch
Note You need to log in before you can comment on or make changes to this bug.