Bug 156583

Summary: Make <a download> a runtime enabled option
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, buildbot, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 102914, 156057    
Bug Blocks: 156056    
Attachments:
Description Flags
Patch
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews114 for mac-yosemite none

Brent Fulgham
Reported 2016-04-14 10:49:53 PDT
The <a download> feature isn't very useful without Blob download support, so we don't want to ship this with production builds of WebKit. However, since we want to encourage experimentation with the feature, we should switch from a compile-time flag to a runtime option.
Attachments
Patch (19.43 KB, patch)
2016-04-14 13:27 PDT, Brent Fulgham 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-yosemite (1.26 MB, application/zip)
2016-04-14 14:14 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-yosemite (849.60 KB, application/zip)
2016-04-14 14:35 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-14 13:17:00 PDT
<rdar://problem/25733449>
Brent Fulgham
Comment 2 2016-04-14 13:27:40 PDT
Created attachment 276416 [details] Patch
Alex Christensen
Comment 3 2016-04-14 13:37:41 PDT
Comment on attachment 276416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276416&action=review > Source/WebCore/html/HTMLAnchorElement.cpp:560 > + if (RuntimeEnabledFeatures::sharedFeatures().downloadAttributeEnabled()) > + downloadAttribute = fastGetAttribute(downloadAttr); Is this the only place we need to check if it's enabled before doing something?
Build Bot
Comment 4 2016-04-14 14:14:49 PDT
Comment on attachment 276416 [details] Patch Attachment 276416 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1157956 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html js/dom/dom-static-property-for-in-iteration.html imported/w3c/web-platform-tests/html/dom/reflection-text.html
Build Bot
Comment 5 2016-04-14 14:14:52 PDT
Created attachment 276427 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-04-14 14:35:50 PDT
Comment on attachment 276416 [details] Patch Attachment 276416 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1158039 New failing tests: js/dom/dom-static-property-for-in-iteration.html
Build Bot
Comment 7 2016-04-14 14:35:53 PDT
Created attachment 276433 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Brent Fulgham
Comment 8 2016-04-14 17:07:32 PDT
To enable the feature after this patch, do the following (on Mac) to test with Safari. defaults write com.apple.Safari com.apple.Safari.ContentPageGroupIdentifier.WebKit2DownloadAttributeEnabled -bool yes
Brent Fulgham
Comment 9 2016-04-14 17:43:30 PDT
I identified the cause of the WK1 test failures and fixed them locally prior to landing. I am able to run WK1 and WK2 tests without errors.
Brent Fulgham
Comment 10 2016-04-14 17:45:41 PDT
Committed r199571: <http://trac.webkit.org/changeset/199571>
Note You need to log in before you can comment on or make changes to this bug.