Bug 157615

Summary: [css-grid] Incorrect parsing when using just 'span" as grid-line value
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: CSSAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, rego, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://bugs.chromium.org/p/chromium/issues/detail?id=563400
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2016-05-12 00:37:53 PDT
If you use "span" alone to reference a grid line it should be considered an invalid declaration (e.g. "grid-column: span;"). https://drafts.csswg.org/css-grid/#typedef-grid-row-start-grid-line This is a port from a Blink patch: https://codereview.chromium.org/1970573004/
Attachments
Patch (18.67 KB, patch)
2016-05-12 00:54 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-05-12 00:54:37 PDT
Created attachment 278708 [details] Patch
WebKit Commit Bot
Comment 2 2016-05-12 02:11:23 PDT
Comment on attachment 278708 [details] Patch Clearing flags on attachment: 278708 Committed r200755: <http://trac.webkit.org/changeset/200755>
WebKit Commit Bot
Comment 3 2016-05-12 02:11:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.