Bug 159705

Summary: [Fetch API] Request and Response url getter should use URL serialization
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 151937    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-07-13 01:23:49 PDT
As per fetch spec, urls should be serialized following https://url.spec.whatwg.org/#concept-url-serializer.
Attachments
Patch (146.98 KB, patch)
2016-07-13 02:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (142.77 KB, patch)
2016-07-14 02:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-07-13 02:06:21 PDT
Created attachment 283496 [details] Patch
Alex Christensen
Comment 2 2016-07-13 08:55:31 PDT
Comment on attachment 283496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283496&action=review > Source/WebCore/platform/URL.h:120 > + bool hasUser()const; > + bool hasPassword()const; > + bool hasQuery()const; > + bool hasFragment() const; All of these should have spaces before const.
youenn fablet
Comment 3 2016-07-14 02:46:13 PDT
Created attachment 283629 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-07-14 03:15:41 PDT
Comment on attachment 283629 [details] Patch for landing Clearing flags on attachment: 283629 Committed r203221: <http://trac.webkit.org/changeset/203221>
WebKit Commit Bot
Comment 5 2016-07-14 03:15:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.