Bug 159808

Summary: Use a private property to implement FetchResponse.body getter
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cgarcia, commit-queue, gyuyoung.kim
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159921    
Bug Blocks: 151937, 159804    
Attachments:
Description Flags
Patch
none
Retrying same patch as it works locally
none
Retrying same patch as it works locally
none
Patch
none
Rebasing none

youenn fablet
Reported 2016-07-15 05:32:45 PDT
Currently, CachedAttribute is used. Using a private property will allow direct use of this property from JS built-ins which will allow easier handling of ReadableStream cloning in Response.clone. Also, this may allow removing some binding custom code.
Attachments
Patch (15.42 KB, patch)
2016-07-15 07:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Retrying same patch as it works locally (15.42 KB, patch)
2016-07-15 08:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Retrying same patch as it works locally (15.44 KB, patch)
2016-07-18 02:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (20.73 KB, patch)
2016-07-19 08:10 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing (15.59 KB, patch)
2016-07-22 01:47 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-07-15 07:16:12 PDT
Created attachment 283760 [details] Patch
youenn fablet
Comment 2 2016-07-15 08:36:11 PDT
Created attachment 283762 [details] Retrying same patch as it works locally
youenn fablet
Comment 3 2016-07-18 02:16:05 PDT
Created attachment 283894 [details] Retrying same patch as it works locally
youenn fablet
Comment 4 2016-07-19 08:10:51 PDT
Created attachment 284005 [details] Patch
WebKit Commit Bot
Comment 5 2016-07-19 08:13:32 PDT
Attachment 284005 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:82: [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:83: [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator' [pylint/E0602] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 6 2016-07-19 10:14:52 PDT
Comment on attachment 284005 [details] Patch This looks reasonable to me. Should it be r?, or are we waiting on https://bugs.webkit.org/show_bug.cgi?id=159921 ?
youenn fablet
Comment 7 2016-07-19 10:17:22 PDT
(In reply to comment #6) > Comment on attachment 284005 [details] > Patch > > This looks reasonable to me. Should it be r?, or are we waiting on > https://bugs.webkit.org/show_bug.cgi?id=159921 ? I would prefer to wait for bug 159921 so that this patch is solely focused on FetchResponse.
youenn fablet
Comment 8 2016-07-22 01:47:30 PDT
Created attachment 284316 [details] Rebasing
WebKit Commit Bot
Comment 9 2016-07-22 23:02:22 PDT
Comment on attachment 284316 [details] Rebasing Clearing flags on attachment: 284316 Committed r203632: <http://trac.webkit.org/changeset/203632>
WebKit Commit Bot
Comment 10 2016-07-22 23:02:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.