Bug 160420

Summary: [Fetch API] Fetch promises should not reject or resolve when ActiveDOMObjects are being stopped
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 151937    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Archive of layout-test-results from ews101 for mac-yosemite
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2016-08-01 12:52:35 PDT
This would lead to crashes, for instance in workers.
Attachments
Patch (11.54 KB, patch)
2016-08-01 13:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (693.85 KB, application/zip)
2016-08-01 14:09 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews101 for mac-yosemite (719.87 KB, application/zip)
2016-08-01 14:10 PDT, Build Bot 		no flags
Details
Patch for landing (9.93 KB, patch)
2016-08-02 00:31 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.15 KB, patch)
2016-08-02 00:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-08-01 13:24:30 PDT
Created attachment 285036 [details] Patch
youenn fablet
Comment 2 2016-08-01 13:26:07 PDT
Some crashes are remaining due to the assertion in WorkerThreadableLoader (loader being null and no callback called).
Build Bot
Comment 3 2016-08-01 14:09:05 PDT
Comment on attachment 285036 [details] Patch Attachment 285036 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1794030 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html
Build Bot
Comment 4 2016-08-01 14:09:07 PDT
Created attachment 285041 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Build Bot
Comment 5 2016-08-01 14:10:08 PDT
Comment on attachment 285036 [details] Patch Attachment 285036 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1794081 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html
Build Bot
Comment 6 2016-08-01 14:10:10 PDT
Created attachment 285043 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Alex Christensen
Comment 7 2016-08-01 21:32:55 PDT
Comment on attachment 285036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285036&action=review watch the bots after landing this. I wouldn't be surprised if more of the tests become flaky. > LayoutTests/TestExpectations:-336 > -# Fetch Worker tests skipped until bug 156737 is resolved Is this still going to be resolved? > LayoutTests/TestExpectations:-338 > -imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html [ Skip ] > -imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html [ Skip ] these seem to have failed on ews.
youenn fablet
Comment 8 2016-08-01 23:06:12 PDT
Thanks for the review. (In reply to comment #7) > Comment on attachment 285036 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285036&action=review > > watch the bots after landing this. I wouldn't be surprised if more of the > tests become flaky. Yes! I was thinking to activate this only for Release mode, but after some testing, it seems Debug is quite stable. > > LayoutTests/TestExpectations:-336 > > -# Fetch Worker tests skipped until bug 156737 is resolved > > Is this still going to be resolved? I cannot reproduce it anymore 8-) > > LayoutTests/TestExpectations:-338 > > -imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html [ Skip ] > > -imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html [ Skip ] > > these seem to have failed on ews. HTTPS tests on WK2 bots are failing due to invalid certificates. But they pass on WK1. I probably need to add specific expectations for these tests.
youenn fablet
Comment 9 2016-08-02 00:31:41 PDT
Created attachment 285081 [details] Patch for landing
youenn fablet
Comment 10 2016-08-02 00:38:52 PDT
Created attachment 285083 [details] Patch for landing
WebKit Commit Bot
Comment 11 2016-08-02 01:08:47 PDT
Comment on attachment 285083 [details] Patch for landing Clearing flags on attachment: 285083 Committed r204020: <http://trac.webkit.org/changeset/204020>
WebKit Commit Bot
Comment 12 2016-08-02 01:08:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.